Silence deprecation output from sidekiq during spec runs#999
Open
mjankowski wants to merge 1 commit intotoptal:masterfrom
Open
Silence deprecation output from sidekiq during spec runs#999mjankowski wants to merge 1 commit intotoptal:masterfrom
mjankowski wants to merge 1 commit intotoptal:masterfrom
Conversation
bbatsov
approved these changes
Feb 25, 2026
Member
bbatsov
left a comment
bbatsov
left a comment
There was a problem hiding this comment.
Makes sense — the old Sidekiq testing API is deprecated since 8.1. Thanks for cleaning this up!
mjankowski
force-pushed
the
sidekiq-deprecation-output
branch
from
7a979a2 to
0227b11
Compare
Contributor
Author
|
I erroneously pushed a removal of this branch while doing branch tidying after other merged PR. I've restored/reopened, but this may need re-approval before merge. Sorry about that. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with 8.1, sidekiq supports this new testing API declaration, and the old style outputs deprecation noise.
Separately, configure logging to remove some output noise during spec runs.
I'm not sure on sidekiq version support here ... its not a gemspec dependency and lock files are ignored - but presumably its a safe assumption that anyone doing development can bundle update to get latest?