Repository navigation
Respect Later and close across onboarding restarts - #658
Draft
simonvanlaak wants to merge 2 commits into
Draft
simonvanlaak wants to merge 2 commits into
simonvanlaak wants to merge 2 commits into
Conversation
This was referenced Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing unfinished required onboarding in Preview 0.12.2 persisted a resume step but left startup free to reopen the tour on every launch. Explicit Later/close now records a separate deferral without claiming setup or practice completed. Startup respects it; Settings → About → Welcome tour explicitly resumes the saved step. Renderer/helper failure still resumes normally, and permission repair and recording admission retain their existing gates.
This is a focused hotfix against the shipped baseline candidate, not a main backport or release-policy change. It addresses the confirmed every-startup recurrence in #653; the earlier screenshot’s unmatched legacy window/helper identity remains unconfirmed. No installed user configuration is edited by this PR.
Independent review found no blocking issue. Regression coverage checks dismissal, serialized progress, saved-step resume, legacy config defaults, crash resume and retained permission repair. Actual Mac close/restart/manual-resume acceptance remains required before shipping. No new release is published by this PR.
Validation: 50 focused onboarding tests and 4 feature-map tests passed locally; independent review completed. A test-fixture correction preserved the permission redirect instead of expecting Shortcut with no grants. The post-commit generic main-integration warning does not change this explicitly pinned baseline target.
A second bounded prerequisite enables the existing private Mac candidate packaging job only for this hotfix branch, as test version0.12.3/build12.3. It retains manual/repository/branch guards, signing/notarization, identity/hash manifest and read-only publication permissions; release/feed mutation and release admission are unchanged. This is an installed-test artifact, not an admitted or published release. 22 Preview contracts, actionlint and embedded Python parsing passed; separate independent workflow review found no blockers. Linux Rust/Desktop UI verification passed for the app-fix commit b0e34f1; Mac Desktop UI passed and Mac Rust was still running when this packaging-only successor was prepared. New exact-head runs are required for the combined candidate.