Skip to content

fix(onboarding): harden setup recovery and practice gates - #669

Merged
simonvanlaak merged 10 commits into
mainfrom
t3/onboarding-practice-controller
Nov 5, 2026
Merged

simonvanlaak merged 10 commits into
mainfrom
t3/onboarding-practice-controller

Conversation

@simonvanlaak

@simonvanlaak simonvanlaak commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Adds an independently buildable onboarding/ TypeScript owner for the branded setup and guided local recording lesson. The React contribution and controller consume Record's public capability contract through injection; Onboarding owns progress, resume/defer, practice attribution and manual paste confirmation. Record #674 is merged, and current main is integrated.

The complete fixture-driven lesson covers color choice and animation, permissions, shortcuts, scoped local-only admission, screen/whiteboard ink, save/copy, manual paste and confirmed opening of the exact saved artifact. Delayed provider readback, stale captures/responses, persistence conflicts, unknown publication, cancellation, reservation cleanup and reconnect are covered. The public Record confirmation helper is bundled into the artifact; there is no runtime dependency on a sibling source tree.

Validation: 33 tests including mounted end-to-end and button interactions; strict source/test typechecks; build; clean component-delivery build and packed runtime consumer; diff checks. Independent read-only re-review approved code candidate c87b34d after reproducing typecheck and all tests. The later commit only updates dependency/readback documentation. Normal guarded push checks apply.

This slice supplies fixture-tested consumer behavior, not installed adoption. Production Record permission/shortcut/pen/stroke/reservation/delivery producers, confirmed artifact-open evidence, a transactional progress adapter and host routing still require implementation and affected native proof. Existing installed routing, sole config writer, Preview releases and #658 remain unchanged. The new delivery descriptor registers an independent library artifact; existing conservative feature-push selection still includes broad root checks for this new owner.

@simonvanlaak
simonvanlaak force-pushed the t3/onboarding-practice-controller branch from fb1f968 to 1b0331a Compare November 5, 2026 12:01
@simonvanlaak simonvanlaak changed the title feat(onboarding): add independent setup and practice package fix(onboarding): harden setup recovery and practice gates Nov 5, 2026
@simonvanlaak
simonvanlaak force-pushed the t3/onboarding-practice-controller branch from 1b0331a to aa0e08f Compare November 5, 2026 12:06
@simonvanlaak
simonvanlaak force-pushed the t3/onboarding-practice-controller branch from aa0e08f to 52418e7 Compare November 5, 2026 12:50
@simonvanlaak
simonvanlaak merged commit 08dc8d5 into main Nov 5, 2026
@simonvanlaak
simonvanlaak deleted the t3/onboarding-practice-controller branch November 5, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant