Repository navigation
fix(onboarding): harden setup recovery and practice gates - #669
Merged
Merged
Conversation
simonvanlaak
force-pushed
the
t3/onboarding-practice-controller
branch
from
November 5, 2026 12:01
fb1f968 to
1b0331a
Compare
simonvanlaak
force-pushed
the
t3/onboarding-practice-controller
branch
from
November 5, 2026 12:06
1b0331a to
aa0e08f
Compare
simonvanlaak
force-pushed
the
t3/onboarding-practice-controller
branch
from
November 5, 2026 12:50
aa0e08f to
52418e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an independently buildable
onboarding/TypeScript owner for the branded setup and guided local recording lesson. The React contribution and controller consume Record's public capability contract through injection; Onboarding owns progress, resume/defer, practice attribution and manual paste confirmation. Record #674 is merged, and current main is integrated.The complete fixture-driven lesson covers color choice and animation, permissions, shortcuts, scoped local-only admission, screen/whiteboard ink, save/copy, manual paste and confirmed opening of the exact saved artifact. Delayed provider readback, stale captures/responses, persistence conflicts, unknown publication, cancellation, reservation cleanup and reconnect are covered. The public Record confirmation helper is bundled into the artifact; there is no runtime dependency on a sibling source tree.
Validation: 33 tests including mounted end-to-end and button interactions; strict source/test typechecks; build; clean component-delivery build and packed runtime consumer; diff checks. Independent read-only re-review approved code candidate c87b34d after reproducing typecheck and all tests. The later commit only updates dependency/readback documentation. Normal guarded push checks apply.
This slice supplies fixture-tested consumer behavior, not installed adoption. Production Record permission/shortcut/pen/stroke/reservation/delivery producers, confirmed artifact-open evidence, a transactional progress adapter and host routing still require implementation and affected native proof. Existing installed routing, sole config writer, Preview releases and #658 remain unchanged. The new delivery descriptor registers an independent library artifact; existing conservative feature-push selection still includes broad root checks for this new owner.