Skip to content

Rename 'delete_application' to 'unregister_application' in clipper_admin#653

Merged
withsmilo merged 3 commits intoucbrise:developfrom
withsmilo:rename_api
May 12, 2019
Merged

Rename 'delete_application' to 'unregister_application' in clipper_admin#653
withsmilo merged 3 commits intoucbrise:developfrom
withsmilo:rename_api

Conversation

@withsmilo
Copy link
Collaborator

@withsmilo withsmilo self-assigned this Mar 22, 2019
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1814/
Test PASSed.

@withsmilo
Copy link
Collaborator Author

Jenkins ok to test

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1820/
Test PASSed.

@withsmilo withsmilo requested review from RehanSD and simon-mo March 25, 2019 15:09
@simon-mo
Copy link
Contributor

@withsmilo can you still create a new method named delete_application and call unregister_application underneath. So existing code doesn’t need to face this breaking change.

In delete application, we can even throw a warning saying this api is deprecated and is aliasing unregistered application

@withsmilo
Copy link
Collaborator Author

@simon-mo , I understand it. It's great idea! I will refactor this PR as soon as possible.

Copy link
Collaborator

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it is good to go if merge conflict is resolved

@withsmilo
Copy link
Collaborator Author

@rkooo567 : I resolved the merge conflict, and added an warning message to the old API(delete_application) reflecting @simon-mo 's opnion.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1947/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1948/
Test FAILed.

@withsmilo
Copy link
Collaborator Author

Jenkins test this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1949/
Test PASSed.

Copy link
Collaborator

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to go. I will just approve because this PR is simple enough. @simon-mo

@withsmilo
Copy link
Collaborator Author

@rkooo567 : Thanks! I will merge this if @simon-mo confirms

@withsmilo withsmilo merged commit 8051a4e into ucbrise:develop May 12, 2019
@withsmilo withsmilo deleted the rename_api branch May 12, 2019 22:29
@withsmilo
Copy link
Collaborator Author

@simon-mo Thanks! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants