Skip to content

Rename 'delete_application' to 'unregister_application' in clipper_admin #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
withsmilo merged 3 commits into from
May 12, 2019
Merged

Rename 'delete_application' to 'unregister_application' in clipper_admin #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cafb80
Rename 'delete_application' to 'unregister_application' in clipper_admin
Mar 22, 2019
0dba823
Merge remote-tracking branch 'official/develop' into rename_api
May 12, 2019
f861256
Old API(delete_application) is redirected to new API(unregister_appli…
May 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion clipper_admin/clipper_admin/clipper_admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,11 @@ def register_application(self, name, input_type, default_output,
app=name))

def delete_application(self, name):
# See: https://github.com/ucbrise/clipper/issues/603
self.logger.warning("[DEPRECATED] Use 'unregister_application' API instead of this.")
self.unregister_application(name)

def unregister_application(self, name):
if not self.connected:
raise UnconnectedException()

Expand All @@ -252,7 +257,7 @@ def delete_application(self, name):
raise ClipperException(msg)
else:
self.logger.info(
"Application {app} was successfully deleted".format(app=name))
"Application {app} was successfully unregistered".format(app=name))

def link_model_to_app(self, app_name, model_name):
"""Routes requests from the specified app to be evaluted by the specified model.
Expand Down
8 changes: 4 additions & 4 deletions integration-tests/clipper_admin_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,14 @@ def test_link_not_registered_model_to_app_fails(self):
self.clipper_conn.link_model_to_app(app_name, not_deployed_model)
self.assertTrue("No model with name" in str(context.exception))

def test_delete_application_correct(self):
def test_unregister_application_correct(self):
input_type = "doubles"
default_output = "DEFAULT"
slo_micros = 30000
app_name = "testapp"
self.clipper_conn.register_application(app_name, input_type,
default_output, slo_micros)
self.clipper_conn.delete_application(app_name)
self.clipper_conn.unregister_application(app_name)
registered_applications = self.clipper_conn.get_all_apps()
self.assertEqual(len(registered_applications), 0)
self.assertTrue(app_name not in registered_applications)
Expand Down Expand Up @@ -850,8 +850,8 @@ def test_remove_inactive_container(self):
'test_register_py_endpoint',
'test_test_predict_function',
'test_build_model_with_custom_packages',
'test_delete_application_correct',
'test_query_specific_model_version'
'test_unregister_application_correct',
'test_query_specific_model_version',
]

LONG_TEST_ORDERING = [
Expand Down