Skip to content

add urllib3 version restriction to requirements.txt#679

Merged
simon-mo merged 3 commits intoucbrise:developfrom
rkooo567:urllib-version-check
Apr 29, 2019
Merged

add urllib3 version restriction to requirements.txt#679
simon-mo merged 3 commits intoucbrise:developfrom
rkooo567:urllib-version-check

Conversation

@rkooo567
Copy link
Collaborator

Details are in #678. Once requests library starts to be compatible with urllib3 >= 1.25, we should remove this line.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1916/
Test PASSed.

@rkooo567
Copy link
Collaborator Author

I added urllib3 constraint to Dev35Dockerfile as well. And the previous CI shows that urllib3==1.25.2 does not generate failed to parse error. I think the problem is within urllib3==1.25.1.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1917/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1918/
Test PASSed.

@simon-mo
Copy link
Contributor

I'm re-running travis. Once it pass we should be fine.

@simon-mo simon-mo merged commit 589f15b into ucbrise:develop Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants