Skip to content

add urllib3 version restriction to requirements.txt #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simon-mo merged 3 commits into from
Apr 29, 2019
Merged

add urllib3 version restriction to requirements.txt #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ae6df0
add urllib3 version restriction to requirements.txt
rkooo567 Apr 29, 2019
4e3d3e4
Changed test dockerfile
rkooo567 Apr 29, 2019
dc3f1c8
Added a comment
rkooo567 Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clipper_admin/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ kubernetes==6.0.0
mock
prometheus_client
redis
# https://github.com/ucbrise/clipper/issues/678.
# It should be removed once urllib3>=1.25 is compatible with requests library
urllib3<1.25
2 changes: 1 addition & 1 deletion dockerfiles/ClipperPy35DevDockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ RUN echo '#!/bin/bash\npython3 "$@"' > /usr/bin/python && \

RUN pip3 install cloudpickle==0.5.* pyzmq==17.0.* requests==2.18.* scikit-learn==0.19.* \
numpy==1.14.* pyyaml==3.12.* docker==3.1.* kubernetes==5.0.* tensorflow==1.6.* mxnet==1.1.* pyspark==2.3.* \
xgboost==0.7.*
xgboost==0.7.* urllib3==1.24.* # CI is broken when urllib3's version is 1.25.1. Delete urllib3==1.24.* later once version compatibility is stabilized

# Install PyTorch
RUN pip3 install torch==1.0.* torchvision==0.2.*
Expand Down