Repository navigation
fix(metrics): a hard client disconnect no longer counts as a failed operation - #5955
Merged
Merged
Conversation
This was referenced Oct 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5946.
When a client hangs up during sync retain, graph, or recall/reflect work stuck on one await, the outright task-cancel path answered 499 with no typed cause. The metrics classifier only treats a 499 chained to
OperationCancelledErroras abandoned, so these requests were counted assuccess=falseinhindsight.operation.total.The 499 is now raised
from OperationCancelledError(token.reason), matching the cooperative path. The response is unchanged.Test: the hard-cancel test now also asserts the 499 is classified as a client cancellation (fails without the fix).