fix: prevent rebuild failures on *NIX with improved handling of symlinks/file#60
Open
EvanDarwin wants to merge 27 commits intovikejs:v0.1from
Open
fix: prevent rebuild failures on *NIX with improved handling of symlinks/file#60EvanDarwin wants to merge 27 commits intovikejs:v0.1from
EvanDarwin wants to merge 27 commits intovikejs:v0.1from
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
) * fix: make `vike-cloudflare` a real Vike extension (vikejs#37) BREAKING CHANGE: update vike to `>=0.4.219` * lint * fix: fix hattip build * chore: vike@^0.4.224 * update * update peer dep * minor refactor * pnpm dedupe * re-run CI * re-run CI * re-run CI * re-run CI * re-run CI --------- Co-authored-by: Joël Charles <joel.charles91@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
BREAKING CHANGE: `vike-cloudflare` is now a Vike extension. Check [migrating from `0.1.x` to `0.2.x`](https://vike.dev/migration/vike-cloudflare)
…s/folders during symlink creation
Author
|
I realize now that this patch may only affect the However, I'd still appreciate getting this merged as it affects the version of |
Member
|
@EvanDarwin I created a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source of this PR was from build failures I was getting related to linked files in
dist/cloudflare/:Attempting to create a linked file at a path that already exists results in an error in *NIX environments.
This patch narrows the error case to only non-symlinked files (let's not
unlinkentire files and directories we're not sure about) so the user can intervene, while allowing the standard build process to succeed.