Skip to content

chore: bump to loaders.gl@4.4#9972

Merged
felixpalmer merged 22 commits intomasterfrom
felix/bump-loaders-4.4
Mar 9, 2026
Merged

chore: bump to loaders.gl@4.4#9972
felixpalmer merged 22 commits intomasterfrom
felix/bump-loaders-4.4

Conversation

@felixpalmer
Copy link
Copy Markdown
Collaborator

@felixpalmer felixpalmer commented Jan 30, 2026 •
edited
Loading

Background

Pulls in alpha release of loaders.gl@4.4 for testing. All website examples work (Tiles 3D Point Cloud example is broken due to auth issue)

Change List

  • Fix up types
  • Use WMSImageSource
  • Migrate to new loadOptions config, e.g. 'core.fetch': ...

felixpalmer
felixpalmer commented Jan 30, 2026
View reviewed changes
Comment thread package.json Outdated
"resolutions": {
"wgsl_reflect": "^1.2.0"
"wgsl_reflect": "^1.2.0",
"@loaders.gl/core": "4.4.0-alpha.12"
Copy link
Copy Markdown
Collaborator Author

@felixpalmer felixpalmer Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this otherwise luma.gl/gltf insists on pulling in loaders.gl@4.2 packages causing errors. Once 4.4 is fully released, this can be removed

@felixpalmer felixpalmer requested a review from ibgreen January 30, 2026 15:41
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 30, 2026 •
edited
Loading

Coverage Status

coverage: 91.005% (-0.006%) from 91.011%
when pulling 154bf5b on felix/bump-loaders-4.4
into 3c69e49 on master.

@chrisgervang chrisgervang added this to the v9.3 milestone Feb 2, 2026
@chrisgervang chrisgervang mentioned this pull request Feb 3, 2026
Closed
31 tasks
@markmasry
Copy link
Copy Markdown

markmasry commented Feb 4, 2026

Mentioning here in case it's related, but the Tiles 3D Point Cloud example seems to be broken: https://deck.gl/examples/tile-3d-layer

@felixpalmer felixpalmer mentioned this pull request Feb 19, 2026
Closed
3 tasks
charlieforward9
charlieforward9 reviewed Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@charlieforward9 charlieforward9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10012 was just version bumps - #10013 was the fixes for the errors in the CI of the former - but it was unfinished. It seems like youre further along here. So ill close my PR's in favor of this one.

@charlieforward9
Copy link
Copy Markdown
Collaborator

charlieforward9 commented Feb 19, 2026

I've been testing the point-cloud example locally and can't get it to render — just a beige screen with no console errors.

What I've tried:

  • Switched LASWorkerLoader → LASLoader (since LASWorkerLoader no longer has parse/parseSync in v4.4)
  • Fixed @loaders.gl/core version mismatch in the example (was resolving to 4.3.4 while @loaders.gl/las was 4.4.0-alpha.13) by adding @loaders.gl/core as a direct dep
  • Disabled workers via loadOptions: {core: {worker: false}}

In all cases the .laz file fetches successfully (200, 1.6MB) and the worker JS loads, but data never reaches onDataLoad. The promise from load() seems to never resolve.

Any ideas on what's needed to get parsing working with the new loader?

@felixpalmer felixpalmer mentioned this pull request Feb 20, 2026
Merged
@felixpalmer
Copy link
Copy Markdown
Collaborator Author

felixpalmer commented Feb 20, 2026

@charlieforward9 thanks for the heads-up, see: visgl/loaders.gl#3297

@charlieforward9
Copy link
Copy Markdown
Collaborator

charlieforward9 commented Feb 20, 2026

Mentioning here in case it's related, but the Tiles 3D Point Cloud example seems to be broken: https://deck.gl/examples/tile-3d-layer

GH page previews?

@charlieforward9
Copy link
Copy Markdown
Collaborator

charlieforward9 commented Feb 20, 2026 •
edited
Loading

Im setting up a draft workflow to help us validate the website quicker. #10019

EDIT #10022

Should we also add some test cases to make sure the screen doesnt show up straight beige, golden images as you called them before?

@charlieforward9 charlieforward9 linked an issue Feb 20, 2026 that may be closed by this pull request
[Bug] Vulnerable transitive dependency: fast-xml-parser@4.5.3 via loaders.gl visgl/deck.gl-community#479
Closed
@felixpalmer felixpalmer changed the title [WIP] bump to loaders.gl@4.4 chore: bump to loaders.gl@4.4 Feb 26, 2026
@felixpalmer felixpalmer mentioned this pull request Feb 26, 2026
Merged
ibgreen
ibgreen reviewed Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this upgrade. A few concerns noted.

@charlieforward9 I think you also did an upgrade attempt, maybe look at my. comments below and compare with approach you took?

Comment thread modules/carto/src/layers/schema/carto-vector-tile-loader.ts Outdated
Comment thread modules/geo-layers/src/mvt-layer/find-index-binary.ts
Comment thread docs/developer-guide/loading-data.md
Comment thread modules/carto/src/layers/schema/carto-vector-tile-loader.ts Outdated
Comment thread modules/core/src/lib/layer.ts Outdated
Comment thread modules/geo-layers/src/wms-layer/wms-layer.ts Outdated
Comment thread modules/geo-layers/src/wms-layer/wms-layer.ts Outdated
Comment thread modules/carto/src/layers/schema/carto-raster-tile-loader.ts Outdated
@felixpalmer felixpalmer mentioned this pull request Mar 4, 2026
Merged
@charlieforward9 charlieforward9 mentioned this pull request Mar 5, 2026
Closed
Copilot AI mentioned this pull request Mar 8, 2026
Closed
charlieforward9
charlieforward9 approved these changes Mar 9, 2026
View reviewed changes
Comment thread examples/website/point-cloud/app.tsx Outdated
Comment thread examples/website/point-cloud/app.tsx
Comment thread modules/carto/src/layers/schema/carto-properties-tile-loader.ts
};
};

const DEFAULT_OPTIONS: CartoPropertiesTileLoaderOptions = {
Copy link
Copy Markdown
Collaborator

@charlieforward9 charlieforward9 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be more maintainable to confirm this to StrictLoaderOptions?

Comment thread modules/carto/src/layers/schema/carto-raster-tile-loader.ts
workerUrl: getWorkerUrl(id, VERSION)
}
};
} as const satisfies CartoRasterTileLoaderOptions;
Copy link
Copy Markdown
Collaborator

@charlieforward9 charlieforward9 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try making the interface updates consistent?

Copy link
Copy Markdown
Collaborator Author

@felixpalmer felixpalmer Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type fixes were done based on earlier comments from @ibgreen - if you like open a follow-up PR to discuss, but I'm not going to address in this PR in order to get it merged

Comment thread modules/carto/src/layers/schema/carto-spatial-tile-loader.ts
parseSync: parseCartoSpatialTile,
worker: true,
options: DEFAULT_OPTIONS
options: DEFAULT_OPTIONS as StrictLoaderOptions
Copy link
Copy Markdown
Collaborator

@charlieforward9 charlieforward9 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@felixpalmer felixpalmer merged commit 01f071e into master Mar 9, 2026
5 checks passed
@felixpalmer felixpalmer deleted the felix/bump-loaders-4.4 branch March 9, 2026 14:24
@felixpalmer felixpalmer mentioned this pull request Mar 10, 2026
Merged
@felixpalmer felixpalmer mentioned this pull request Apr 1, 2026
Merged
@ibgreen ibgreen mentioned this pull request May 2, 2026
Open
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibgreen ibgreen ibgreen left review comments

@charlieforward9 charlieforward9 charlieforward9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v9.3

Development

Successfully merging this pull request may close these issues.

[Bug] Vulnerable transitive dependency: fast-xml-parser@4.5.3 via loaders.gl

6 participants

@felixpalmer @coveralls @markmasry @charlieforward9 @ibgreen @chrisgervang