-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: bump to loaders.gl@4.4 #9972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
01fc916
7c29867
a727ff9
f5dde3c
83ad1ef
fb3bc8a
de3a33d
24a191c
403811f
b900cf2
e4ca48a
f939449
1079a7b
ee548cc
8b48c6c
e835ff4
231ded5
a3d04e8
4364b4e
81728b3
62db12c
154bf5b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| // SPDX-License-Identifier: MIT | ||
| // Copyright (c) vis.gl contributors | ||
|
|
||
| import {LoaderOptions, LoaderWithParser} from '@loaders.gl/loader-utils'; | ||
| import {LoaderOptions, LoaderWithParser, StrictLoaderOptions} from '@loaders.gl/loader-utils'; | ||
| import type {RasterMetadata} from '@carto/api-client'; | ||
|
|
||
| import {TileReader} from './carto-raster-tile'; | ||
|
|
@@ -20,12 +20,12 @@ type CartoRasterTileLoaderOptions = LoaderOptions & { | |
| }; | ||
| }; | ||
|
|
||
| const DEFAULT_OPTIONS: CartoRasterTileLoaderOptions = { | ||
| const DEFAULT_OPTIONS = { | ||
| cartoRasterTile: { | ||
| metadata: null, | ||
| workerUrl: getWorkerUrl(id, VERSION) | ||
| } | ||
| }; | ||
| } as const satisfies CartoRasterTileLoaderOptions; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Try making the interface updates consistent?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The type fixes were done based on earlier comments from @ibgreen - if you like open a follow-up PR to discuss, but I'm not going to address in this PR in order to get it merged |
||
|
|
||
| const CartoRasterTileLoader: LoaderWithParser = { | ||
| name: 'CARTO Raster Tile', | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| // SPDX-License-Identifier: MIT | ||
| // Copyright (c) vis.gl contributors | ||
|
|
||
| import {LoaderOptions, LoaderWithParser} from '@loaders.gl/loader-utils'; | ||
| import {LoaderOptions, LoaderWithParser, StrictLoaderOptions} from '@loaders.gl/loader-utils'; | ||
|
|
||
| import {Tile, TileReader} from './carto-spatial-tile'; | ||
| import {parsePbf} from './tile-loader-utils'; | ||
|
|
@@ -38,7 +38,7 @@ const CartoSpatialTileLoader: LoaderWithParser = { | |
| parseCartoSpatialTile(arrayBuffer, options), | ||
| parseSync: parseCartoSpatialTile, | ||
| worker: true, | ||
| options: DEFAULT_OPTIONS | ||
| options: DEFAULT_OPTIONS as StrictLoaderOptions | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ^ |
||
| }; | ||
|
|
||
| function parseCartoSpatialTile( | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.