fix: helm-only release is a no-op when chart name lacks helm- prefix#406
Draft
fix: helm-only release is a no-op when chart name lacks helm- prefix#406
helm- prefix#406Conversation
The plan_helm_release CLI command and find_helm_chart_bazel_target
function now accept chart names both with and without the internal
"helm-" prefix.
Previously, passing "manmanv2-control-services" (as documented in
SKILL.md and as users naturally do) would fail to match the internally
stored chart name "helm-manmanv2-control-services", resulting in an
empty chart plan and a no-op release.
Affected functions:
- plan_helm_release in cli.py: matching now also checks c['name'] == f"helm-{req}"
- find_helm_chart_bazel_target in helm.py: same prefix-aware matching
Tests added to test_exclude_demo.py:
- TestPlanHelmReleaseChartNameMatching: 4 cases covering name with/without prefix
- TestFindHelmChartBazelTargetNameMatching: 3 cases covering both lookup paths
Agent-Logs-Url: https://github.com/whale-net/everything/sessions/f524cf2a-da50-4661-8fe3-14ef78f8ba7f
Co-authored-by: QMasterMoo <3915399+QMasterMoo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/whale-net/everything/sessions/f524cf2a-da50-4661-8fe3-14ef78f8ba7f Co-authored-by: QMasterMoo <3915399+QMasterMoo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix helm-only release no-op issue
fix: helm-only release is a no-op when chart name lacks Apr 12, 2026
helm- prefix
Member
|
@copilot I have fixed the firewall, try again without go build/test |
Contributor
Author
Tests now run successfully with Bazel:
Note: Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chart names are stored internally with a
helm-prefix (e.g.,helm-manmanv2-control-services), but by convention workflow inputs omit it (e.g.,manmanv2-control-services). Bothplan_helm_releaseandfind_helm_chart_bazel_targetused exact-string matching, so user-provided names never matched, producing an empty plan and silently skipping all build/publish steps.Changes
cli.py—plan_helm_release: matching now also checksc['name'] == f"helm-{req}", accepting names with or without the prefixhelm.py—find_helm_chart_bazel_target: same prefix-aware matching applied to the lower-level lookup used bybuild-helm-charttest_exclude_demo.py: addedTestPlanHelmReleaseChartNameMatching(4 cases) andTestFindHelmChartBazelTargetNameMatching(3 cases) covering both name forms, mixed input, and unknown chart behaviorWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
pigweed.googlesource.com/usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin REDACTED(dns block)/usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin REDACTED -collect-logs(dns block)/usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin REDACTED rything(dns block)If you need me to access, download, or install something from one of these locations, you can either: