Skip to content

Remove Experimental Flag and Card Disable for Single Persist Connection Logic#1430

Merged
sachiniSam merged 2 commits intowso2:feature/persist-improvementsfrom
sachiniSam:persistImprovements
Feb 16, 2026
Merged

Remove Experimental Flag and Card Disable for Single Persist Connection Logic#1430
sachiniSam merged 2 commits intowso2:feature/persist-improvementsfrom
sachiniSam:persistImprovements

Conversation

@sachiniSam
Copy link
Contributor

@sachiniSam sachiniSam commented Feb 13, 2026

Purpose

With this PR, the Persist Connection creation logic that was gated by the experimental enable check has been removed. Additionally, the card disabling behavior when only a single persist connection exists has also been removed.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

UI Component Development

Specify the reason if following are not followed.

  • Added reusable UI components to the ui-toolkit. Follow the intructions when adding the componenent.
  • Use ui-toolkit components wherever possible. Run npm run storybook from the root directory to view current components.
  • Matches with the native VSCode look and feel.

Manage Icons

Specify the reason if following are not followed.

  • Added Icons to the font-wso2-vscode. Follow the instructions.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Summary by CodeRabbit

  • New Features
    • Database connector is now consistently available in the connection options without experimental feature gating restrictions.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The pull request removes experimental feature gating from the connection popup component, eliminating state management, effects, and conditional logic that controlled Database connector visibility. The code now consistently displays both API and Database options without flag-based conditions, reducing complexity through conditional simplification.

Changes

Cohort / File(s) Summary
Feature Flag Removal
workspaces/ballerina/ballerina-visualizer/src/views/BI/Connection/AddConnectionPopup/index.tsx
Eliminated experimental feature gating logic, including state management and effects that fetched/checked experimental flags. Simplified connector option rendering to always show Database option, streamlined getConnectorCreationOptions function, and removed conditional UI elements (disabled states, tooltips). Reduced overall code by 90 lines through conditional branch removal.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 No more flags to flip and bind,
The Database shines, now easy to find,
Experimental gates fall away with glee,
Simpler code flows wild and free! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete. Only the Purpose section is filled; Goals, Approach, and all other required sections contain template placeholders without substantive content. Complete the Goals section explaining how removal addresses the purpose, add technical details in Approach, and fill critical sections like Release note, Documentation, and test environment information.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely summarizes the main changes: removing experimental flag and card disable behavior for persist connection logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into feature/persist-improvements

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sachiniSam
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sachiniSam sachiniSam merged commit f69b40d into wso2:feature/persist-improvements Feb 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants