Merge Feature/persist improvements changes to release/bi-1.8.x#1480
Merge Feature/persist improvements changes to release/bi-1.8.x#1480sachiniSam merged 4 commits intorelease/bi-1.8.xfrom
Conversation
Remove Experimental Flag and Card Disable for Single Persist Connection Logic
Sync feature/persist-imporvement branch with release/bi-1.8.x
📝 WalkthroughWalkthroughRemoved experimental feature flag handling, state management, and UI elements from the AddConnectionPopup component. The changes eliminate conditional logic that gated database/API visibility behind experimental flags, simplify ConnectorOptionCard styling, and consolidate the introductory text to a single version. The database option is now consistently available without experimental gating. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
workspaces/ballerina/ballerina-visualizer/src/views/BI/Connection/AddConnectionPopup/index.tsx (1)
589-618: Drop the now-redundantConnectorOptionTitleContainerwrapper.
ConnectorOptionTitleContainer(defined at lines 112–118) usesjustify-content: space-between, which was meaningful when anExperimentalBadgesibling sat next to the title. With the badge removed, the wrapper now holds a single child and its layout rule is a no-op. The API-spec card above doesn't use this container at all — aligning the database card to the same pattern removes dead markup.♻️ Proposed cleanup
- <ConnectorOptionTitleContainer> - <ConnectorOptionTitle>Connect to a Database</ConnectorOptionTitle> - </ConnectorOptionTitleContainer> + <ConnectorOptionTitle>Connect to a Database</ConnectorOptionTitle>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@workspaces/ballerina/ballerina-visualizer/src/views/BI/Connection/AddConnectionPopup/index.tsx` around lines 589 - 618, Remove the now-redundant ConnectorOptionTitleContainer wrapper from the Database connector card: replace the JSX that wraps <ConnectorOptionTitle> inside ConnectorOptionTitleContainer so that <ConnectorOptionTitle> is a direct child of ConnectorOptionContent (matching the API-spec card pattern), and then remove the ConnectorOptionTitleContainer styled-component definition (lines ~112–118) if it is no longer used elsewhere to avoid dead markup and unused styles; ensure spacing and layout remain correct after the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@workspaces/ballerina/ballerina-visualizer/src/views/BI/Connection/AddConnectionPopup/index.tsx`:
- Around line 589-618: Remove the now-redundant ConnectorOptionTitleContainer
wrapper from the Database connector card: replace the JSX that wraps
<ConnectorOptionTitle> inside ConnectorOptionTitleContainer so that
<ConnectorOptionTitle> is a direct child of ConnectorOptionContent (matching the
API-spec card pattern), and then remove the ConnectorOptionTitleContainer
styled-component definition (lines ~112–118) if it is no longer used elsewhere
to avoid dead markup and unused styles; ensure spacing and layout remain correct
after the change.
2 participants
Purpose
Currently this includes the #1430 fix
Goals
Approach
UI Component Development
npm run storybookfrom the root directory to view current components.Manage Icons
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning
Summary by CodeRabbit
Refactor
Style