Skip to content

Fix hash spreading in HashPartitionConsumer#4364

Merged
Darych merged 1 commit intoydb-platform:mainfrom
Darych:YQL-18235-hash
May 13, 2024
Merged

Fix hash spreading in HashPartitionConsumer#4364
Darych merged 1 commit intoydb-platform:mainfrom
Darych:YQL-18235-hash

Conversation

@Darych
Copy link
Contributor

@Darych Darych commented May 7, 2024 •
edited
Loading

Changelog entry

Fix hash spreading in HashPartitionConsumer

Changelog category

  • Improvement

Additional information

...

@github-actions
Copy link

github-actions bot commented May 7, 2024 •
edited
Loading

⚪ 2024-05-07 13:30:42 UTC Pre-commit check for ade561e has started.
⚪ 2024-05-07 13:30:44 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-07 13:33:47 UTC Build successful.
⚪ 2024-05-07 13:35:30 UTC Tests are running...
🔴 2024-05-07 15:31:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70645 57545 0 2 13089 9

@github-actions
Copy link

github-actions bot commented May 7, 2024 •
edited
Loading

⚪ 2024-05-07 13:39:07 UTC Pre-commit check for ade561e has started.
⚪ 2024-05-07 13:39:09 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-07 13:42:27 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 7, 2024 •
edited
Loading

⚪ 2024-05-07 13:49:53 UTC Pre-commit check for ade561e has started.
⚪ 2024-05-07 13:49:56 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-07 13:52:51 UTC Build successful.
⚪ 2024-05-07 13:54:40 UTC Tests are running...
🔴 2024-05-07 15:42:33 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11984 11817 0 45 111 11

@Darych Darych marked this pull request as ready for review May 8, 2024 09:16
@Darych Darych requested review from a team as code owners May 8, 2024 09:16
@Darych Darych force-pushed the YQL-18235-hash branch from c547b92 to be9bb5e Compare May 8, 2024 17:27
@Darych Darych self-assigned this May 8, 2024
@github-actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

⚪ 2024-05-08 17:31:12 UTC Pre-commit check for 299a68a has started.
⚪ 2024-05-08 17:31:15 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-08 17:34:31 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

⚪ 2024-05-08 17:31:13 UTC Pre-commit check for 299a68a has started.
⚪ 2024-05-08 17:31:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-08 17:34:21 UTC Build successful.
⚪ 2024-05-08 17:36:08 UTC Tests are running...
🔴 2024-05-08 19:30:53 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70768 57590 0 3 13168 7

@github-actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

⚪ 2024-05-08 17:31:16 UTC Pre-commit check for 299a68a has started.
⚪ 2024-05-08 17:31:19 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-08 17:33:53 UTC Build successful.
⚪ 2024-05-08 17:35:44 UTC Tests are running...
🔴 2024-05-08 19:21:05 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11972 11863 0 38 65 6

@Darych Darych force-pushed the YQL-18235-hash branch from be9bb5e to 26d086c Compare May 9, 2024 11:19
@github-actions
Copy link

github-actions bot commented May 9, 2024 •
edited
Loading

⚪ 2024-05-09 11:22:45 UTC Pre-commit check for 5a17e31 has started.
⚪ 2024-05-09 11:22:48 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-09 11:26:15 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 9, 2024 •
edited
Loading

⚪ 2024-05-09 11:22:54 UTC Pre-commit check for 5a17e31 has started.
⚪ 2024-05-09 11:22:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-09 11:25:39 UTC Build successful.
⚪ 2024-05-09 11:27:35 UTC Tests are running...
🔴 2024-05-09 13:16:55 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11978 11836 0 38 96 8

@github-actions
Copy link

github-actions bot commented May 9, 2024 •
edited
Loading

⚪ 2024-05-09 11:22:57 UTC Pre-commit check for 5a17e31 has started.
⚪ 2024-05-09 11:23:00 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-09 11:26:03 UTC Build successful.
⚪ 2024-05-09 11:27:49 UTC Tests are running...
🔴 2024-05-09 13:23:56 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70805 57608 0 2 13188 7

@github-actions
Copy link

github-actions bot commented May 11, 2024 •
edited
Loading

⚪ 2024-05-11 09:42:07 UTC Pre-commit check for bf797b0 has started.
⚪ 2024-05-11 09:42:09 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-11 09:58:06 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 11, 2024 •
edited
Loading

⚪ 2024-05-11 09:42:12 UTC Pre-commit check for bf797b0 has started.
⚪ 2024-05-11 09:42:15 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-11 09:45:06 UTC Build successful.
⚪ 2024-05-11 09:46:57 UTC Tests are running...
🔴 2024-05-11 11:31:11 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11982 11879 0 35 61 7

@github-actions
Copy link

github-actions bot commented May 11, 2024 •
edited
Loading

⚪ 2024-05-11 09:42:39 UTC Pre-commit check for bf797b0 has started.
⚪ 2024-05-11 09:42:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-11 09:46:01 UTC Build successful.
⚪ 2024-05-11 09:47:46 UTC Tests are running...
🔴 2024-05-11 11:42:52 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70808 57610 0 1 13188 9

@Darych Darych requested review from Hor911 and vitstn May 13, 2024 11:17
Hor911
Hor911 approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@Hor911 Hor911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Проверял на стенде - нарушение хеширование по orderkey в TPC-H для 64 тасок per join исправляется

@Darych Darych merged commit e3c776f into ydb-platform:main May 13, 2024
Hor911 pushed a commit to Hor911/ydb that referenced this pull request May 13, 2024
@Darych @Hor911
Fix hash spreading in HashPartitionConsumer (ydb-platform#4364)
bb36731
Hor911 pushed a commit to Hor911/ydb that referenced this pull request May 13, 2024
@Darych @Hor911
Fix hash spreading in HashPartitionConsumer (ydb-platform#4364)
ffe5234
@GrigoriyPA GrigoriyPA mentioned this pull request May 16, 2024
Closed
This was referenced May 16, 2024
Merged
Merged
@serbel324 serbel324 mentioned this pull request May 24, 2024
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@Darych @MrLolthe1st
Fix hash spreading in HashPartitionConsumer (ydb-platform#4364)
ac71542
gridnevvvit added a commit to gridnevvvit/ydb that referenced this pull request Sep 4, 2024
@gridnevvvit
Revert "Fix hash spreading in HashPartitionConsumer (ydb-platform#4364)"
85fb1b0 
This reverts commit e3c776f.
gridnevvvit added a commit that referenced this pull request Sep 4, 2024
@gridnevvvit
Revert "Fix hash spreading in HashPartitionConsumer (#4364)" (#8752)
d358371
gridnevvvit added a commit to gridnevvvit/ydb that referenced this pull request Sep 4, 2024
@gridnevvvit
Revert "Fix hash spreading in HashPartitionConsumer (ydb-platform#4364)"
5d90aef 
This reverts commit e3c776f.
gridnevvvit added a commit that referenced this pull request Sep 5, 2024
@gridnevvvit
Revert "Fix hash spreading in HashPartitionConsumer (#4364)" (#8753)
fe3a015
gridnevvvit added a commit that referenced this pull request Sep 5, 2024
@gridnevvvit
Revert "Fix hash spreading in HashPartitionConsumer (#4364)"
f51926b 
This reverts commit e3c776f.
@niksaveliev niksaveliev mentioned this pull request Sep 9, 2024
Merged
gridnevvvit added a commit to gridnevvvit/ydb that referenced this pull request Sep 9, 2024
@gridnevvvit
Revert "Fix hash spreading in HashPartitionConsumer (ydb-platform#4364)"
83d4881 
This reverts commit e3c776f.
gridnevvvit added a commit that referenced this pull request Sep 9, 2024
@gridnevvvit
Revert "Fix hash spreading in HashPartitionConsumer (#4364)" (#8980)
5909a74
@niksaveliev niksaveliev mentioned this pull request Sep 12, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Sep 17, 2024
@gridnevvvit @uzhastik
Revert "Fix hash spreading in HashPartitionConsumer (ydb-platform#4364)…
7ef1b8f 
…" (ydb-platform#8980)
This was referenced Oct 29, 2024
Closed
Closed
@lll-phill-lll lll-phill-lll mentioned this pull request Nov 14, 2024
Open
@serbel324 serbel324 mentioned this pull request Nov 19, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 21, 2025
Closed
maximyurchuk pushed a commit to maximyurchuk/ydb that referenced this pull request Mar 11, 2025
@Darych @maximyurchuk
Fix hash spreading in HashPartitionConsumer (ydb-platform#4364)
caeb030
maximyurchuk added a commit to maximyurchuk/ydb that referenced this pull request Mar 11, 2025
@maximyurchuk
Revert "Fix hash spreading in HashPartitionConsumer (ydb-platform#4364)"
13f82ae 
This reverts commit caeb030.
@maximyurchuk maximyurchuk mentioned this pull request Apr 2, 2025
Merged
This was referenced Jun 3, 2025
Closed
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jul 28, 2025
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jan 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nepal nepal nepal approved these changes

@Hor911 Hor911 Hor911 approved these changes

@vitstn vitstn Awaiting requested review from vitstn

Assignees

@Darych Darych

Labels

improvement new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Darych @nepal @Hor911