Skip to content

dont create delete flag column in indexation#7082

Merged
ivanmorozov333 merged 7 commits intoydb-platform:mainfrom
ivanmorozov333:dont-create-delete-flags-column
Jul 26, 2024
Merged

dont create delete flag column in indexation#7082
ivanmorozov333 merged 7 commits intoydb-platform:mainfrom
ivanmorozov333:dont-create-delete-flags-column

Conversation

@ivanmorozov333
Copy link
Collaborator

@ivanmorozov333 ivanmorozov333 commented Jul 25, 2024

if it is not necessary

  • Improvement

@github-actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 09:17:09 UTC Pre-commit check for a41e0a5 has started.
⚪ 2024-07-25 09:20:00 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-25 11:27:45 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9617 9016 0 94 326 181

🟢 2024-07-25 11:28:43 UTC Build successful.
🟡 2024-07-25 11:29:31 UTC ydbd size 5.2 GiB changed* by +147.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 833f929 merge: a41e0a5 diff diff %
ydbd size 5 560 959 344 Bytes 5 561 110 304 Bytes +147.4 KiB +0.003%
ydbd stripped size 1 197 617 392 Bytes 1 197 650 224 Bytes +32.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 09:17:19 UTC Pre-commit check for a41e0a5 has started.
⚪ 2024-07-25 09:20:05 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-25 09:28:50 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 09:19:48 UTC Pre-commit check for a41e0a5 has started.
⚪ 2024-07-25 09:22:35 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-25 10:52:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13748 12402 0 2 1326 18

⚪ 2024-07-25 10:54:02 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-25 11:01:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 3 0 2 0 15

⚪ 2024-07-25 11:03:18 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-25 11:11:22 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 1 0 2 0 15

🟢 2024-07-25 11:13:02 UTC Build successful.
🟢 2024-07-25 11:13:37 UTC ydbd size 8.1 GiB changed* by +63.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 833f929 merge: a41e0a5 diff diff %
ydbd size 8 661 919 088 Bytes 8 661 983 744 Bytes +63.1 KiB +0.001%
ydbd stripped size 471 320 640 Bytes 471 324 160 Bytes +3.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

zverevgeny
zverevgeny previously approved these changes Jul 25, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 14:36:20 UTC Pre-commit check for 8bd2f46 has started.
⚫ 2024-07-25 14:36:24 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 14:38:18 UTC Pre-commit check for d3448a6 has started.
⚪ 2024-07-25 14:41:17 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-25 16:17:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13754 12409 0 3 1326 16

⚪ 2024-07-25 16:19:24 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-25 16:26:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19 (only retried tests) 9 0 1 0 9

⚪ 2024-07-25 16:28:03 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-25 16:35:37 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11 (only retried tests) 1 0 1 0 9

🟢 2024-07-25 16:36:44 UTC Build successful.
🟢 2024-07-25 16:37:23 UTC ydbd size 8.1 GiB changed* by +48 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: fcb8576 merge: d3448a6 diff diff %
ydbd size 8 666 452 080 Bytes 8 666 452 128 Bytes +48 Bytes +0.000%
ydbd stripped size 471 495 744 Bytes 471 496 000 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 14:38:26 UTC Pre-commit check for d3448a6 has started.
⚪ 2024-07-25 14:41:17 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-25 16:47:46 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9611 9024 0 89 322 176

🟢 2024-07-25 16:48:42 UTC Build successful.
🟢 2024-07-25 16:49:31 UTC ydbd size 5.2 GiB changed* by +800 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: fcb8576 merge: d3448a6 diff diff %
ydbd size 5 564 201 536 Bytes 5 564 202 336 Bytes +800 Bytes +0.000%
ydbd stripped size 1 198 212 720 Bytes 1 198 213 424 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 14:39:49 UTC Pre-commit check for d3448a6 has started.
⚪ 2024-07-25 14:42:57 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-25 14:48:15 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024

⚪ 2024-07-26 05:52:15 UTC Pre-commit check for bc277d9 has started.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024

⚪ 2024-07-26 05:53:24 UTC Pre-commit check for bc277d9 has started.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 06:04:54 UTC Pre-commit check for bc277d9 has started.
⚪ 2024-07-26 06:07:48 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-26 08:13:20 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9642 9062 0 82 323 175

🟢 2024-07-26 08:14:17 UTC Build successful.
🟢 2024-07-26 08:15:06 UTC ydbd size 5.2 GiB changed* by +5.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 34b6297 merge: bc277d9 diff diff %
ydbd size 5 564 663 224 Bytes 5 564 668 768 Bytes +5.4 KiB +0.000%
ydbd stripped size 1 198 266 832 Bytes 1 198 269 328 Bytes +2.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny linked an issue Jul 26, 2024 that may be closed by this pull request
CS fails when downgrade from 24.3 to 24.2 #7049
Closed
@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Jul 26, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 26, 2024
@github-actions
Copy link

github-actions bot commented Jul 26, 2024

⚪ 2024-07-26 09:36:19 UTC Pre-commit check for d6fcba6 has started.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 09:41:48 UTC Pre-commit check for d6fcba6 has started.
⚪ 2024-07-26 09:48:29 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-26 10:46:13 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 09:42:03 UTC Pre-commit check for d6fcba6 has started.
⚪ 2024-07-26 09:48:31 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-26 10:46:14 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 10:50:33 UTC Pre-commit check for 7db87cf has started.
⚪ 2024-07-26 10:53:21 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-26 11:01:42 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 11:00:25 UTC Pre-commit check for 7db87cf has started.
⚫ 2024-07-26 11:01:39 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 11:03:45 UTC Pre-commit check for ead68e6 has started.
⚪ 2024-07-26 11:07:11 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-26 12:43:13 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 11:05:29 UTC Pre-commit check for ead68e6 has started.
⚪ 2024-07-26 11:08:57 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 12:38:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13785 12435 0 3 1330 17

⚪ 2024-07-26 12:39:52 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-26 12:43:44 UTC ydbd size 8.1 GiB changed* by +6.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6064125 merge: ead68e6 diff diff %
ydbd size 8 667 494 768 Bytes 8 667 501 520 Bytes +6.6 KiB +0.000%
ydbd stripped size 471 530 176 Bytes 471 532 832 Bytes +2.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-07-26 12:43:45 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 11:06:39 UTC Pre-commit check for ead68e6 has started.
⚪ 2024-07-26 11:09:50 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 11:17:41 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 12:45:16 UTC Pre-commit check for 2c82d54 has started.
⚪ 2024-07-26 12:48:38 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-26 13:08:04 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 12:47:38 UTC Pre-commit check for 2c82d54 has started.
⚪ 2024-07-26 12:50:42 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 12:56:53 UTC Build successful.

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Jul 26, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 26, 2024
@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 13:12:20 UTC Pre-commit check for 179bd73 has started.
⚪ 2024-07-26 13:15:13 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 14:45:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13780 12439 0 3 1325 13

⚪ 2024-07-26 14:47:19 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-26 14:55:39 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 (only retried tests) 7 0 0 0 9

🟢 2024-07-26 14:56:48 UTC Build successful.
🟢 2024-07-26 14:57:29 UTC ydbd size 8.1 GiB changed* by -5.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7ea1c14 merge: 179bd73 diff diff %
ydbd size 8 667 996 048 Bytes 8 667 990 304 Bytes -5.6 KiB -0.000%
ydbd stripped size 471 549 728 Bytes 471 547 808 Bytes -1.9 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 13:20:09 UTC Pre-commit check for 179bd73 has started.
⚪ 2024-07-26 13:23:33 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-26 15:36:45 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9653 9058 0 91 333 171

🟢 2024-07-26 15:37:42 UTC Build successful.
🟢 2024-07-26 15:38:41 UTC ydbd size 5.2 GiB changed* by -14.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7ea1c14 merge: 179bd73 diff diff %
ydbd size 5 565 090 360 Bytes 5 565 075 736 Bytes -14.3 KiB -0.000%
ydbd stripped size 1 198 339 088 Bytes 1 198 332 432 Bytes -6.5 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 merged commit 9785f6a into ydb-platform:main Jul 26, 2024
@ivanmorozov333 ivanmorozov333 deleted the dont-create-delete-flags-column branch July 26, 2024 16:06
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jul 28, 2024
@ivanmorozov333 @zverevgeny
dont create delete flag column in indexation (ydb-platform#7082)
3a8f6a5
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jul 28, 2024
@ivanmorozov333 @zverevgeny
dont create delete flag column in indexation (ydb-platform#7082)
5219891
@zverevgeny zverevgeny mentioned this pull request Jul 28, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 30, 2024
Merged
@zverevgeny zverevgeny mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CS fails when downgrade from 24.3 to 24.2

2 participants

@ivanmorozov333 @zverevgeny