Skip to content

Dont create delete flags column if not necessary#7169

Merged
zverevgeny merged 6 commits intoydb-platform:stable-24-3from
zverevgeny:dont-create-delete-flags-column_24_3
Jul 29, 2024
Merged

Dont create delete flags column if not necessary#7169
zverevgeny merged 6 commits intoydb-platform:stable-24-3from
zverevgeny:dont-create-delete-flags-column_24_3

Conversation

@zverevgeny
Copy link
Collaborator

@zverevgeny zverevgeny commented Jul 28, 2024 •
edited
Loading

Integrate this PR #7082 plus required refactoring made before it

After this change CS will create new column DELETE_FLAG when the first DELETE operation is executed. Currently it creates this column at startup, that make database incompatible with the previous version.

@zverevgeny zverevgeny linked an issue Jul 28, 2024 that may be closed by this pull request
CS fails when downgrade from 24.3 to 24.2 #7049
Closed
@github-actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚪ 2024-07-28 13:49:17 UTC Pre-commit check for 8432391 has started.
⚪ 2024-07-28 13:52:03 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-28 13:54:45 UTC Build failed. see the build logs.
🔴 2024-07-28 13:54:46 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚪ 2024-07-28 13:51:10 UTC Pre-commit check for 8432391 has started.
⚪ 2024-07-28 13:53:57 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-28 13:57:06 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚪ 2024-07-28 13:51:13 UTC Pre-commit check for 8432391 has started.
⚪ 2024-07-28 13:54:09 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-28 13:57:05 UTC Build failed. see the build logs.
🔴 2024-07-28 13:57:06 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚪ 2024-07-28 14:38:29 UTC Pre-commit check for fe9225e has started.
⚪ 2024-07-28 14:41:51 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-28 15:17:33 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚪ 2024-07-28 14:40:03 UTC Pre-commit check for fe9225e has started.
⚪ 2024-07-28 14:42:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-28 15:24:22 UTC Build successful.
⚪ 2024-07-28 15:24:39 UTC Tests are running...
🔴 2024-07-28 17:26:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11247 10667 0 84 321 175

🟡 2024-07-28 17:27:01 UTC ydbd size 5.2 GiB changed* by +556.7 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: a196e19 merge: fe9225e diff diff %
ydbd size 5 612 291 120 Bytes 5 612 861 168 Bytes +556.7 KiB +0.010%
ydbd stripped size 1 210 289 544 Bytes 1 210 185 640 Bytes -101.5 KiB -0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚪ 2024-07-28 14:40:15 UTC Pre-commit check for fe9225e has started.
⚪ 2024-07-28 14:43:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-28 15:45:37 UTC Build successful.
⚪ 2024-07-28 15:45:56 UTC Tests are running...
🔴 2024-07-28 17:30:34 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39767 34529 0 2 5221 15

🟡 2024-07-28 17:31:18 UTC ydbd size 8.1 GiB changed* by +1.9 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: a196e19 merge: fe9225e diff diff %
ydbd size 8 721 536 544 Bytes 8 723 501 104 Bytes +1.9 MiB +0.023%
ydbd stripped size 476 948 488 Bytes 476 904 456 Bytes -43.0 KiB -0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny added the rebase-and-check Rebase PR with the current base branch and check label Jul 28, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 28, 2024
@github-actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚪ 2024-07-28 18:45:34 UTC Pre-commit check for fe9225e has started.
⚪ 2024-07-28 18:48:22 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-28 18:53:54 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚪ 2024-07-28 18:45:41 UTC Pre-commit check for fe9225e has started.
⚪ 2024-07-28 18:48:38 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-28 19:12:16 UTC Build successful.
⚪ 2024-07-28 19:12:34 UTC Tests are running...
🔴 2024-07-28 21:22:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11250 10665 0 85 324 176

🟡 2024-07-28 21:22:56 UTC ydbd size 5.2 GiB changed* by +556.7 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: a196e19 merge: fe9225e diff diff %
ydbd size 5 612 291 120 Bytes 5 612 861 168 Bytes +556.7 KiB +0.010%
ydbd stripped size 1 210 289 544 Bytes 1 210 185 640 Bytes -101.5 KiB -0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚪ 2024-07-28 18:45:46 UTC Pre-commit check for fe9225e has started.
⚪ 2024-07-28 18:48:44 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-28 19:27:05 UTC Build successful.
⚪ 2024-07-28 19:27:23 UTC Tests are running...
🔴 2024-07-28 21:16:29 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39764 34526 0 2 5221 15

🟡 2024-07-28 21:17:16 UTC ydbd size 8.1 GiB changed* by +1.9 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: a196e19 merge: fe9225e diff diff %
ydbd size 8 721 536 544 Bytes 8 723 501 104 Bytes +1.9 MiB +0.023%
ydbd stripped size 476 948 488 Bytes 476 904 456 Bytes -43.0 KiB -0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny marked this pull request as ready for review July 29, 2024 04:55
@zverevgeny zverevgeny requested a review from a team as a code owner July 29, 2024 04:55
@zverevgeny zverevgeny merged commit e8f2390 into ydb-platform:stable-24-3 Jul 29, 2024
@niksaveliev niksaveliev mentioned this pull request Aug 15, 2024
Closed
This was referenced Aug 16, 2024
Closed
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 23, 2024
Closed
@siarheivesialou siarheivesialou mentioned this pull request Aug 28, 2024
Closed
@swalrus1 swalrus1 mentioned this pull request Sep 3, 2024
Closed
This was referenced Oct 29, 2024
Closed
Closed
@serbel324 serbel324 mentioned this pull request Nov 19, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 21, 2025
Closed
This was referenced Jun 3, 2025
Closed
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jul 28, 2025
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jan 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CS fails when downgrade from 24.3 to 24.2

3 participants

@zverevgeny @fomichev3000 @ivanmorozov333