Add a new CopyFilesBuildPhase, "Embed ExtensionKit Extensions"

[mtj0928]

close #1224

As @freddi-kit mentioned on #1224, extension kit extensions must be embedded as a separate copyFilesPhase from app extensions.
In this PR, I changed the followings related to extension kit extensions.

• Added "Embed ExtensionKit Extensions" as a new CopyFilesBuildPhase 0371a6c
• Fixed explicitFileType for extension kit extensions bf71a5d

FYI:
XcodeProj resolves the fileType from the file extension only, but extension kit extension and app extension have different fileType even though they have the same file extension.
So, I added productType as a new argument to fileType(path), to resolve the fileType from the combination of the file extension and the product type.

[freddi-kit]

Perfect from my sight

[freddi-kit]

It might be better to write like below to consider the other addtional future cases of dependencyTarget.type when dependencyTarget.type.isExtension is true

else if dependencyTarget.type.isExtension {
     // we may add other properties == 
     if dependencyTarget.type == .extensionKitExtension {
        extensionKitExtensions.append(embedFile)
     } else {
         extensions.append(embedFile)
     }
}

[yonaskolb]

Great work @mtj0928!
Would it be possible for you to add an example extension in Test/Fixtures/TestProject? That's a project that tries to have every single XcodeGen feature in it, so that any diffs in the generation are tracked.

[mtj0928]

Thank you for your reviews!

@freddi-kit
I fixed the if statement structure based on your comment.

@yonaskolb
I added a new example extension, but the new product type com.apple.product-type.extensionkit-extension is supported on only Xcode 14 or later.
Thus, CI failed on Xcode 12.5.1 and Xcode 13.0.
Do you have any ideas to pass the check?

[yonaskolb]

To fix CI properly, we'd need a seperate Xcode14 fixture project that only runs in a seperate action with Xcode 14 in Github Actions.
If you feel comfortable doing that, that would be fantastic. Otherwise we can wait until Xcode 14 launches before merging this.

[alessionossa]

Otherwise we can wait until Xcode 14 launches before merging this.

This would be a blow to the teams that rely on XcodeGen and would like to implement ExtensionKit Extensions like AppIntents in time for iOS 16 launch. 😥

[yonaskolb]

Otherwise we can wait until Xcode 14 launches before merging this.

This would be a blow to the teams that rely on XcodeGen and would like to implement ExtensionKit Extensions like AppIntents in time for iOS 16 launch. 😥

@alessionossa makes sense, I can appreciate that. @mtj0928 if the CI changes are too much work, I'm happy with you just commenting out the changes to the project.yml in this PR for now. Up to you 👍

[mtj0928]

@yonaskolb
I'd like to try adding a new fixture project which runs with Xcode 14, but even if I do it, I think we cannot run it because GitHub Actions don't support Xcode 14 yet.
Thus, in this PR, I will comment out the changes in the project.yml.

I'd like to try creating the new fixture project for Xcode 14 as another issue.

[mtj0928]

I've created a new issue #1232.
(Please modify it if needed.)

[freddi-kit]

I think it is ready for merging 👍

[freddi-kit]

@yonaskolb I think we can merge it in master

[yonaskolb]

Great, thanks @mtj0928! 🙏

[yonaskolb]

Released in 2.31.0