Skip to content

Add support for the steep LSP#102

Merged
vitallium merged 3 commits intozed-extensions:mainfrom
wouterken:wc/add_steep_lsp
Jun 3, 2025
Merged

Add support for the steep LSP#102
vitallium merged 3 commits intozed-extensions:mainfrom
wouterken:wc/add_steep_lsp

Conversation

@wouterken
Copy link
Contributor

@wouterken wouterken commented Jun 1, 2025

This PR aims to add support for the soutaro/steep LSP.
Because by default the steep check command will type-check an entire project (which can be quite expensive on a large repository), the configuration defaults to only enabling the LSP if a root-level Steepfile exists (at which point it's clear you've opted into gradual typechecking with Steep).

You can disable this with lsp: setting:

{
  "steep": {
    "settings": {
      "require_root_steepfile": false
    }
}

Note sure if that's reasonable default behavior..

@vitallium
Copy link
Collaborator

Thanks for adding steep! I think before we land this we need to disable steep explicitly in default Zed settings here.

@notpeter Hi, sorry for the direct ping but do you know if it's possible to avoid modifying the default.json file to tweak the LS servers for a language?

@vitallium vitallium self-requested a review June 2, 2025 16:54
@notpeter
Copy link
Contributor

notpeter commented Jun 2, 2025

@notpeter Hi, sorry for the direct ping but do you know if it's possible to avoid modifying the default.json file to tweak the LS servers for a language?

Sadly, I think that is what's currently required until there is a better story for:

Tag me in a PR with that and I'll merge and sneak it into stable/preview so we don't have to wait two weeks to merge this PR.

Copy link
Collaborator

@vitallium vitallium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! I fixed one small linter offence to land this PR. Thank you!

@vitallium vitallium merged commit 1f802be into zed-extensions:main Jun 3, 2025
3 checks passed
@wouterken wouterken deleted the wc/add_steep_lsp branch June 3, 2025 19:54
@vitallium
Copy link
Collaborator

@notpeter Hi, sorry for the direct ping but do you know if it's possible to avoid modifying the default.json file to tweak the LS servers for a language?

Sadly, I think that is what's currently required until there is a better story for:

Tag me in a PR with that and I'll merge and sneak it into stable/preview so we don't have to wait two weeks to merge this PR.

@notpeter hi! Here is the PR that adds steep and sorbet for the Ruby language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants