Adding support for the 36442 base build#187
Open
StoicLoofah wants to merge 20 commits intoGraylinKim:lotvfrom
Open
Adding support for the 36442 base build#187StoicLoofah wants to merge 20 commits intoGraylinKim:lotvfrom
StoicLoofah wants to merge 20 commits intoGraylinKim:lotvfrom
Conversation
sc2reader/resources.py
Outdated
Owner
There was a problem hiding this comment.
You need to put an upper bound on this condition now. Same as the ones before it.
Owner
|
I don't have any newer replays myself but you figured it out pretty well. Fix the comment above and I'd be happy to merge. |
Author
|
Updated with the condition as you mentioned. If you want to play around with it yourself, here's a replay on this build http://lotv.spawningtool.com/903/download/ |
Author
|
I have been using my own fork in production, and it has been working here. @GraylinKim poking if you want to merge this into your branch? |
add LotV-related tests
test now passes, meaning that we can parse the replay without barfing. test doesn't check the parsed data at all; just confirms that no exception is thrown.
handle 3.0 replays, work in progress.
Conflicts: sc2reader/readers.py sc2reader/resources.py
…ays now parse. Conflicts: sc2reader/events/game.py
Conflicts: test_replays/test_all.py
Conflicts: test_replays/test_all.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@GraylinKim I feel like an idiot: I had no idea how the different numbers in the s2protocol file corresponded to the types, and then I realized it was just a dictionary into the types. After that, it was easy to figure out.
For posterity (and anyone else who might want to contribute), I:
and it seemed like that worked.
Let me know if there's anything that I might have missed. I'm popping this into production for lotv.spawningtool.com right now, so I will let you know if I see any other errors.