Repository navigation
Require a selection before responding to a multiple-choice HITL request - #75643
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:translations
area:UI
Lee-W
marked this pull request as ready for review
October 26, 2026 09:37
Lee-W
requested review from
bbovenzi,
choo121600,
guan404ming,
henry3260,
jason810496,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 26, 2026 09:37
amoghrajesh
reviewed
Oct 26, 2026
Disable Respond and show a "Select at least one option" hint when a multiple=True Human-in-the-loop request has no option chosen, instead of sending an empty chosen_options that the API rejects with a generic 422. Related: apache#75532
…tions - Block the Respond button on an empty selection whenever it replaces the option buttons, not only for multiple-choice requests - Treat an empty string or missing value as empty for single-choice requests
Lee-W
force-pushed
the
hitl-multiple-require-selection
branch
from
October 26, 2026 10:11
30a8a61 to
80c652c
Compare
amoghrajesh
approved these changes
Oct 26, 2026
Lee-W
enabled auto-merge (squash)
October 26, 2026 10:33
1 task done
aaiss0927
added a commit
to aaiss0927/airflow-1
that referenced
this pull request
Oct 28, 2026
Add the five missing Korean translations to restore key parity with the English locale. These keys were added to the English locale after the open batch PR apache#75415 branched, so they are not covered there: - dag.json: versions.pathOccurrences_one/_other, versions.pathOccurrencesAtLeast_one/_other (added by apache#75433) - hitl.json: response.selectAtLeastOne (added by apache#75643) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
choo121600
pushed a commit
that referenced
this pull request
Oct 29, 2026
* i18n(ko): add missing translations(Oct 27) Add the five missing Korean translations to restore key parity with the English locale. These keys were added to the English locale after the open batch PR #75415 branched, so they are not covered there: - dag.json: versions.pathOccurrences_one/_other, versions.pathOccurrencesAtLeast_one/_other (added by #75433) - hitl.json: response.selectAtLeastOne (added by #75643) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * i18n(ko): add translations for keys introduced in #75326 Covers the three keys added to en after this branch was cut: xcom.columns.timestamp (browse), dagDetails.bundleVersion (common, matching the existing versionDetails.bundleVersion wording), and the sort aria-label (components). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A18rBgPJ6X4oXAzsecJjnz --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a request is still pending and its
Respondbutton is shown (amultiple=Truerequest, a single-choice request with more than 4 options, or one with preloaded options) and no option is chosen, the form now disables Respond and shows a "Select at least one option" hint.handleSubmitalso returns early in that state, so an emptychosen_optionsis never sent. Requests rendered as per-option buttons (4 or fewer options, notmultiple) and Approve/Reject requests behave as before.What
When a
multiple=Truerequest is still pending and has no option chosen, the form now disables Respond and shows a "Select at least one option" hint (newresponse.selectAtLeastOnekey, added inenandzh-TW).handleSubmitalso returns early in that state, so an emptychosen_optionsis never sent. Preselected defaults and single-choice requests behave as before.closes: #75532
Was generative AI tooling used to co-author this PR?
Generated-by: [Claude] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.