Skip to content

i18n(ko): add missing translations(Oct 27) - #75740

Merged
choo121600 merged 2 commits into
apache:mainfrom
aaiss0927:i18n-ko-missing-oct27
Oct 29, 2026
Merged

choo121600 merged 2 commits into
apache:mainfrom
aaiss0927:i18n-ko-missing-oct27

Conversation

@aaiss0927

@aaiss0927 aaiss0927 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Add the eight missing Korean (ko) translations that restore key parity with the English locale:

File Key English Korean
dag.json versions.pathOccurrences_one {{count, number}} change shares this path 변경 {{count, number}}개가 이 경로를 공유합니다
dag.json versions.pathOccurrences_other {{count, number}} changes share this path 변경 {{count, number}}개가 이 경로를 공유합니다
dag.json versions.pathOccurrencesAtLeast_one At least {{count, number}} change shares this path 변경 {{count, number}}개 이상이 이 경로를 공유합니다
dag.json versions.pathOccurrencesAtLeast_other At least {{count, number}} changes share this path 변경 {{count, number}}개 이상이 이 경로를 공유합니다
hitl.json response.selectAtLeastOne Select at least one option 옵션을 하나 이상 선택하세요
browse.json xcom.columns.timestamp Timestamp 타임스탬프
common.json dagDetails.bundleVersion Bundle Version 번들 버전
components.json sort sort 정렬

Notes:


Screenshots

Validation message when no option of a multiple-choice HITL request is selected (response.selectAtLeastOne):

hitl_select_at_least_one

Tooltip on the ×3 badge in the Dag Versions diff, viewed without Dag code read access (versions.pathOccurrences_other):

versions_path_occurrences

Truncated diff (Max changes = 1): the ×3+ badge with the lower-bound tooltip (versions.pathOccurrencesAtLeast_other). The English "At least 3 changes" summary line is summaryAtLeast, which is covered by #75415:

versions_path_occurrences_at_least

The three #75326 keys are single-word labels — the XCom Timestamp column header, the Bundle Version row in Dag details, and a screen-reader-only sort aria-label — so no dedicated screenshots for them.


Test

breeze ui check-translation-completeness --language ko

test_check_translation_completeness_oct28

On this branch (rebased onto main, so the #75326 keys are in the en baseline) the eight keys are no longer reported: hitl.json and browse.json 100%, dag.json missing 22 → 18, common.json 12 → 11, components.json 7 → 6. The remaining 38 missing / 13 unused keys are exactly the set being handled by #75415, so ko coverage reaches 100% once both PRs land.

cc @onestn @noeunkim


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    Claude Fable5

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@aaiss0927
aaiss0927 requested a review from choo121600 as a code owner October 27, 2026 09:48
@boring-cyborg boring-cyborg Bot added area:translations area:UI Related to UI/UX. For Frontend Developers. translation:ko labels Oct 27, 2026

@yuseok89 yuseok89 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks, the translations read well and stay consistent with the existing ko terms. Since #75326 three new keys landed in en, and it would be nice to add them here as well.

@yuseok89

Copy link
Copy Markdown
Contributor

@choo121600, could you take a look at this one and #75415 when you have a moment? Both fill in missing ko keys without overlapping.

@aaiss0927

Copy link
Copy Markdown
Contributor Author

Thanks for the review @yuseok89! Done — added the three keys that landed with #75326:

  • browse.json → xcom.columns.timestamp = "타임스탬프" (same wording as dashboard.json)
  • common.json → dagDetails.bundleVersion = "번들 버전" (consistent with the existing versionDetails.bundleVersion in components.json)
  • components.json → sort = "정렬" (the TableList sort-button aria-label)

Also re-checked against #75415 — still no overlap: the remaining ko gaps are exactly the ones it fills.

Add the five missing Korean translations to restore key parity with
the English locale. These keys were added to the English locale after
the open batch PR apache#75415 branched, so they are not covered there:

- dag.json: versions.pathOccurrences_one/_other,
  versions.pathOccurrencesAtLeast_one/_other (added by apache#75433)
- hitl.json: response.selectAtLeastOne (added by apache#75643)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@aaiss0927
aaiss0927 force-pushed the i18n-ko-missing-oct27 branch from 265097b to 36e2fa7 Compare October 28, 2026 03:58
Covers the three keys added to en after this branch was cut:
xcom.columns.timestamp (browse), dagDetails.bundleVersion (common,
matching the existing versionDetails.bundleVersion wording), and the
sort aria-label (components).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A18rBgPJ6X4oXAzsecJjnz
@aaiss0927
aaiss0927 force-pushed the i18n-ko-missing-oct27 branch from 36e2fa7 to 6a45a2a Compare October 28, 2026 05:18

@choo121600 choo121600 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributiion :)

@choo121600
choo121600 merged commit 34ad14c into apache:main Oct 29, 2026
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:translations area:UI Related to UI/UX. For Frontend Developers. translation:ko

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants