Repository navigation
i18n(ko): add missing translations(Oct 27) - #75740
Merged
Merged
Conversation
shahar1
approved these changes
Oct 27, 2026
Contributor
|
@choo121600, could you take a look at this one and #75415 when you have a moment? Both fill in missing ko keys without overlapping. |
Contributor
Author
|
Thanks for the review @yuseok89! Done — added the three keys that landed with #75326:
Also re-checked against #75415 — still no overlap: the remaining ko gaps are exactly the ones it fills. |
Add the five missing Korean translations to restore key parity with the English locale. These keys were added to the English locale after the open batch PR apache#75415 branched, so they are not covered there: - dag.json: versions.pathOccurrences_one/_other, versions.pathOccurrencesAtLeast_one/_other (added by apache#75433) - hitl.json: response.selectAtLeastOne (added by apache#75643) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
aaiss0927
force-pushed
the
i18n-ko-missing-oct27
branch
from
October 28, 2026 03:58
265097b to
36e2fa7
Compare
Covers the three keys added to en after this branch was cut: xcom.columns.timestamp (browse), dagDetails.bundleVersion (common, matching the existing versionDetails.bundleVersion wording), and the sort aria-label (components). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A18rBgPJ6X4oXAzsecJjnz
aaiss0927
force-pushed
the
i18n-ko-missing-oct27
branch
from
October 28, 2026 05:18
36e2fa7 to
6a45a2a
Compare
choo121600
approved these changes
Oct 29, 2026
choo121600
left a comment
Member
There was a problem hiding this comment.
Thanks for contributiion :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the eight missing Korean (ko) translations that restore key parity with the English locale:
dag.jsonversions.pathOccurrences_onedag.jsonversions.pathOccurrences_otherdag.jsonversions.pathOccurrencesAtLeast_onedag.jsonversions.pathOccurrencesAtLeast_otherhitl.jsonresponse.selectAtLeastOnebrowse.jsonxcom.columns.timestampcommon.jsondagDetails.bundleVersioncomponents.jsonsortNotes:
versions.pathOccurrences*by UI: Show Dag version diff occurrence count on the path instead of a column #75433 andresponse.selectAtLeastOneby Require a selection before responding to a multiple-choice HITL request #75643 — so they are not covered by that PR. This PR intentionally contains only keys outside i18n(ko): Add missing translations (Oct 23) #75415's scope and does not overlap it (same de-duplication approach as i18n(ko): add missing translations(Jul 17) #70005). related: i18n(ko): Add missing translations (Oct 23) #75415_one/_othershare the same Korean string, following the existing ko locale convention (e.g.versions.summary_one/_other).pathOccurrences*strings are the tooltip on the×Nbadge in the Dag Versions diff, shown when several changes are merged into one row because they share a path. The badge appears only for users without Dag code read access (values-redacted mode); theAtLeastvariant is used when the diff was truncated by the max-changes limit (×N+).selectAtLeastOneis the validation message in the Human-in-the-loop response form when no option of a multiple-choice request is selected.xcom.columns.timestampis the XCom list column header;dagDetails.bundleVersionis the row label in the Dag details panel (wording matches the existingversionDetails.bundleVersion= "번들 버전");sortis the aria-label of the sort toggle in data-table headers.Screenshots
Validation message when no option of a multiple-choice HITL request is selected (
response.selectAtLeastOne):Tooltip on the
×3badge in the Dag Versions diff, viewed without Dag code read access (versions.pathOccurrences_other):Truncated diff (Max changes = 1): the
×3+badge with the lower-bound tooltip (versions.pathOccurrencesAtLeast_other). The English "At least 3 changes" summary line issummaryAtLeast, which is covered by #75415:The three #75326 keys are single-word labels — the XCom Timestamp column header, the Bundle Version row in Dag details, and a screen-reader-only
sortaria-label — so no dedicated screenshots for them.Test
breeze ui check-translation-completeness --language koOn this branch (rebased onto main, so the #75326 keys are in the
enbaseline) the eight keys are no longer reported:hitl.jsonandbrowse.json100%,dag.jsonmissing 22 → 18,common.json12 → 11,components.json7 → 6. The remaining 38 missing / 13 unused keys are exactly the set being handled by #75415, so ko coverage reaches 100% once both PRs land.cc @onestn @noeunkim
Was generative AI tooling used to co-author this PR?
Claude Fable5
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.