Skip to content

feat(autoware_cuda_dependency_meta): pass -fno-lto compile flag to downstream packages of autoware_cuda_dependency_meta - #11115

Merged
xmfcx merged 1 commit into
autowarefoundation:mainfrom
esteve:fix-avoid-lto-cuda
Dec 26, 2025
Merged

xmfcx merged 1 commit into
autowarefoundation:mainfrom
esteve:fix-avoid-lto-cuda

Conversation

@esteve

@esteve esteve commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Description

This PR adds a CONFIG_EXTRAS file so that downstream dependencies disable LTO. The Debian packaging tools (sbuild, fakeroot, etc.) enable LTO by default for all packages, but that optimization is not supported in CUDA and causes link errors.

See https://forums.developer.nvidia.com/t/link-time-optimization-with-cuda-on-linux-flto/55530

Related links

https://forums.developer.nvidia.com/t/link-time-optimization-with-cuda-on-linux-flto/55530

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions Bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Aug 4, 2025
@github-actions

github-actions Bot commented Aug 4, 2025 •

Copy link
Copy Markdown

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 4, 2025
@esteve
esteve requested review from mitsudome-r and xmfcx August 4, 2025 14:25
@esteve

esteve commented Aug 4, 2025

Copy link
Copy Markdown
Contributor Author

@mitsudome-r @xmfcx This change is needed so that CUDA-dependent packages can be built in the Debian buildfarm.

@codecov

codecov Bot commented Aug 4, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.21%. Comparing base (a635dd5) to head (9814c30).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11115      +/-   ##
==========================================
+ Coverage   18.06%   18.21%   +0.14%     
==========================================
  Files        1802     1804       +2     
  Lines      125161   125407     +246     
  Branches    43614    43904     +290     
==========================================
+ Hits        22613    22838     +225     
- Misses      83705    83950     +245     
+ Partials    18843    18619     -224     
Flag Coverage Δ *Carryforward flag
daily 20.47% <ø> (ø) Carriedforward from a635dd5
daily-cuda 18.06% <ø> (ø) Carriedforward from a635dd5
differential 8.08% <ø> (?)
total-cuda 18.06% <ø> (ø) Carriedforward from a635dd5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stale

stale Bot commented Nov 24, 2025

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale Bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 24, 2025
@esteve
esteve force-pushed the fix-avoid-lto-cuda branch from 0064311 to f6eba60 Compare November 25, 2025 13:04
@stale stale Bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Nov 25, 2025
…wnstream packages of autoware_cuda_dependency_meta

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@xmfcx

xmfcx commented Dec 26, 2025

Copy link
Copy Markdown
Contributor

@xmfcx
xmfcx enabled auto-merge (squash) December 26, 2025 10:32
@xmfcx
xmfcx merged commit 89d2243 into autowarefoundation:main Dec 26, 2025
44 of 46 checks passed
@github-project-automation github-project-automation Bot moved this from To Triage to Done in Software Working Group Dec 26, 2025
xtk8532704 pushed a commit to tier4/autoware_universe that referenced this pull request Jan 7, 2026
…wnstream packages of autoware_cuda_dependency_meta (autowarefoundation#11115)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: xtk8532704 <1041084556@qq.com>
simonranjith pushed a commit to simonranjith/autoware_universe that referenced this pull request Jan 16, 2026
…wnstream packages of autoware_cuda_dependency_meta (autowarefoundation#11115)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
simonranjith pushed a commit to simonranjith/autoware_universe that referenced this pull request Jan 17, 2026
…wnstream packages of autoware_cuda_dependency_meta (autowarefoundation#11115)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
k-uta pushed a commit to tier4/autoware_universe that referenced this pull request Jan 28, 2026
…wnstream packages of autoware_cuda_dependency_meta (autowarefoundation#11115)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
KeisukeShima pushed a commit to KeisukeShima/autoware.universe that referenced this pull request Mar 16, 2026
…wnstream packages of autoware_cuda_dependency_meta (autowarefoundation#11115)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
mkquda pushed a commit to tier4/autoware_universe that referenced this pull request Mar 16, 2026
…wnstream packages of autoware_cuda_dependency_meta (autowarefoundation#11115)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
mkquda pushed a commit to tier4/autoware_universe that referenced this pull request Apr 22, 2026
…wnstream packages of autoware_cuda_dependency_meta (autowarefoundation#11115)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants