Skip to content

fix(cuda_scan_ground_segmentation): add missing include - #11850

Merged
xmfcx merged 1 commit into
autowarefoundation:mainfrom
xmfcx:fix/cuda_scan_ground_segmentation
Jan 9, 2026
Merged

xmfcx merged 1 commit into
autowarefoundation:mainfrom
xmfcx:fix/cuda_scan_ground_segmentation

Conversation

@xmfcx

@xmfcx xmfcx commented Jan 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

It failed compilation for me. (I checked, it actually passed in CI)

This adds missing include for FLT_MAX usage, #include <cfloat>

mfc@whale:~/projects/autoware$ nvcc -V
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2025 NVIDIA Corporation
Built on Fri_Feb_21_20:23:50_PST_2025
Cuda compilation tools, release 12.8, V12.8.93
Build cuda_12.8.r12.8/compiler.35583870_0

https://github.com/autowarefoundation/autoware/blob/8085940071de40222441e61a47b53468eed13ac6/amd64.env#L10-L12

Maybe it would compile for CUDA 12.4 but it is better to be on the safe side.

Error

/home/mfc/projects/autoware/src/universe/autoware_universe/perception/autoware_ground_segmentation_cuda/src/cuda_scan_ground_segmentation/cuda_scan_ground_segmentation_filter.cu(46): error: identifier "FLT_MAX" is undefined
      new_cell.gnd_height_min = FLT_MAX;
                                ^

/home/mfc/projects/autoware/src/universe/autoware_universe/perception/autoware_ground_segmentation_cuda/src/cuda_scan_ground_segmentation/cuda_scan_ground_segmentation_filter.cu(286): error: identifier "FLT_MAX" is undefined
    float t_gnd_height_min = FLT_MAX;
                             ^

2 errors detected in the compilation of "/home/mfc/projects/autoware/src/universe/autoware_universe/perception/autoware_ground_segmentation_cuda/src/cuda_scan_ground_segmentation/cuda_scan_ground_segmentation_filter.cu".
CMake Error at cuda_ground_segmentation_lib_generated_cuda_scan_ground_segmentation_filter.cu.o.Release.cmake:280 (message):
  Error generating file
  /home/mfc/projects/autoware/build/autoware_ground_segmentation_cuda/CMakeFiles/cuda_ground_segmentation_lib.dir/src/cuda_scan_ground_segmentation/./cuda_ground_segmentation_lib_generated_cuda_scan_ground_segmentation_filter.cu.o

How was this PR tested?

Locally and in CI.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx
xmfcx requested a review from anhnv3991 January 9, 2026 13:53
@xmfcx xmfcx self-assigned this Jan 9, 2026
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 9, 2026
@github-actions github-actions Bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 9, 2026
@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jan 9, 2026
@xmfcx
xmfcx requested a review from badai-nguyen January 9, 2026 14:00
@xmfcx
xmfcx enabled auto-merge (squash) January 9, 2026 14:02
@xmfcx
xmfcx requested a review from manato January 9, 2026 14:03
@codecov

codecov Bot commented Jan 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.99%. Comparing base (f12e8ab) to head (5c66929).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11850      +/-   ##
==========================================
- Coverage   18.02%   17.99%   -0.03%     
==========================================
  Files        1809     1811       +2     
  Lines      125537   125728     +191     
  Branches    43624    43793     +169     
==========================================
- Hits        22624    22623       -1     
- Misses      84064    84256     +192     
  Partials    18849    18849              
Flag Coverage Δ *Carryforward flag
daily 20.46% <ø> (ø) Carriedforward from 7fb4b78
daily-cuda 18.01% <ø> (ø) Carriedforward from 7fb4b78
differential-cuda 0.00% <ø> (?)
total-cuda 18.01% <ø> (+<0.01%) ⬆️ Carriedforward from 7fb4b78

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xmfcx
xmfcx requested a review from mitsudome-r January 9, 2026 14:04
@xmfcx
xmfcx merged commit 6d60e75 into autowarefoundation:main Jan 9, 2026
64 of 69 checks passed
@github-project-automation github-project-automation Bot moved this from To Triage to Done in Software Working Group Jan 9, 2026
@xmfcx
xmfcx deleted the fix/cuda_scan_ground_segmentation branch January 9, 2026 14:54
simonranjith pushed a commit to simonranjith/autoware_universe that referenced this pull request Jan 16, 2026
simonranjith pushed a commit to simonranjith/autoware_universe that referenced this pull request Jan 17, 2026
k-uta pushed a commit to tier4/autoware_universe that referenced this pull request Jan 28, 2026
KeisukeShima pushed a commit to KeisukeShima/autoware.universe that referenced this pull request Mar 16, 2026
mkquda pushed a commit to tier4/autoware_universe that referenced this pull request Mar 16, 2026
mkquda pushed a commit to tier4/autoware_universe that referenced this pull request Apr 22, 2026
tier4-autoware-public-bot Bot pushed a commit to tier4/autoware_universe_sensing_perception that referenced this pull request Jul 16, 2026
tier4-autoware-public-bot Bot pushed a commit to tier4/autoware_universe_sensing_perception that referenced this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants