[mikeedi]

Description

Fix autoware_component_monitor memory parsing for top RES values without a unit suffix.

top may print the RES column as a plain integer which is KiB, but the previous implementation interpreted suffix-less values as bytes, under-reporting RSS by ~1024x for small processes. This PR treats suffix-less RES values as KiB and adds a unit test for the parser.

Related links

Parent Issue:

#12215

How was this PR tested?

colcon test --packages-select autoware_component_monitor

Notes for reviewers

• The change is limited to RES parsing (process_memory_bytes) and keeps suffix handling (k/m/g/...) intact.
• Added test_top_memory_parser to cover both suffix-less and suffixed inputs.

Interface changes

None.

Effects on system behavior

process_memory_bytes will increase by ~1024x in cases where top prints RES without a suffix (previously under-reported).

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity.

[codecov]

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.58%. Comparing base (4fb338f) to head (94ee875).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...toware_component_monitor/src/top_memory_parser.hpp	83.33%	2 Missing ⚠️
...e_component_monitor/src/component_monitor_node.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12217      +/-   ##
==========================================
+ Coverage   37.56%   37.58%   +0.01%     
==========================================
  Files        2028     2029       +1     
  Lines      141955   141961       +6     
==========================================
+ Hits        53331    53349      +18     
+ Misses      88624    88612      -12     

Flag	Coverage Δ		*Carryforward flag
full-suite	37.57% <ø> (+<0.01%)	⬆️	Carriedforward from 3425931

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[xmfcx]

I restored the // NOLINTNEXTLINE(readability/casting) line above unit_map. cpplint reads std::function<std::uint64_t(double)> as a C-style cast, and this failed pre-commit-lite.

[xmfcx]

I checked top on Ubuntu 24.04: RES without a suffix is in KiB, the same as the rss value of ps. So the old bytes reading was wrong by a factor of 1024. The package builds, and its 29 tests pass locally. CI is green.