Repository navigation
feat(autoware_carla_interface): allow explicit carla_map override in launch - #13193
Merged
hakuturu583 merged 3 commits intoAug 18, 2026
Merged
Conversation
…launch Add an optional `carla_map` launch argument that, when non-empty, overrides the CARLA map/level name that is otherwise derived from the basename of `map_path`. This is useful for CARLA levels whose name does not match the Autoware map directory name. The resolution is moved into a `carla_map_resolved` let: when the `carla_map` argument is empty (the default), the name is derived from `map_path` exactly as before, so behavior is unchanged unless the user opts in. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
hakuturu583
added
component:simulation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
8 tasks
hakuturu583
marked this pull request as draft
August 14, 2026 07:03
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13193 +/- ##
==========================================
- Coverage 20.33% 20.26% -0.07%
==========================================
Files 1942 1948 +6
Lines 136595 136371 -224
Branches 48724 48633 -91
==========================================
- Hits 27781 27641 -140
- Misses 86291 86345 +54
+ Partials 22523 22385 -138
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Downstream consumer: the autoware_launch side that forwards this argument from |
hakuturu583
marked this pull request as ready for review
August 17, 2026 05:30
hakuturu583
enabled auto-merge (squash)
August 17, 2026 11:46
5 tasks done
github-project-automation
Bot
moved this from To Triage
to Done
in Software Working Group
hakuturu583
added a commit
to hakuturu583/autoware.universe
that referenced
this pull request
Aug 20, 2026
… with upstream main The branch was cut before autowarefoundation#13195, autowarefoundation#13196, autowarefoundation#13198, autowarefoundation#13193 and autowarefoundation#13210 merged into main, so its diff against main had started to show those already-landed fixes (steering-curve sort, has_attribute guards, map_origin_x/y, carla_map override, no_rendering_mode) as reverted. Merge main back in so the branch only carries its own README changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
TetsuKawa
pushed a commit
to TetsuKawa/autoware_universe
that referenced
this pull request
Sep 7, 2026
…launch (autowarefoundation#13193) Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
TetsuKawa
pushed a commit
to TetsuKawa/autoware_universe
that referenced
this pull request
Sep 7, 2026
shmpwk
pushed a commit
to tier4/pilot_auto_simulation
that referenced
this pull request
Sep 14, 2026
TetsuKawa
pushed a commit
to TetsuKawa/autoware_universe
that referenced
this pull request
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an optional
carla_maplaunch argument that, when non-empty, overrides the CARLA map/level name that is otherwise derived from the basename ofmap_path. This is useful when the CARLA level name does not match the Autoware map directory name.Map-name resolution is factored into a
carla_map_resolved<let>. When thecarla_mapargument is empty (the default), the name is derived frommap_pathexactly as before, so behavior is unchanged unless the user opts in.This is one of a series of small enabler PRs toward CARLA 0.10.0 support, and is a launch-only change.
How was this PR tested?
carla_mapis empty (the default), the value derived frommap_pathis identical to the previous behavior.Backward compatibility
carla_mapdefaults to"". Unless the user opts in, the resolved result is the same as today and thecarla_mapvalue passed to the node is unchanged.Related PR
e2e_simulator.launch.xml(Draft; to be merged after this PR).