Repository navigation
feat(mrm_operator): add driving mode active flag - #13249
Merged
sasakisasaki merged 5 commits intoAug 26, 2026
Merged
sasakisasaki merged 5 commits into
sasakisasaki merged 5 commits into
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
github-actions
Bot
added
the
component:system
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
3 of 18 tasks
isamu-takagi
marked this pull request as ready for review
August 26, 2026 05:15
isamu-takagi
requested review from
TomohitoAndo,
mkuri and
sasakisasaki
as code owners
August 26, 2026 05:15
sasakisasaki
left a comment
sasakisasaki
left a comment
Contributor
There was a problem hiding this comment.
Personally, there looks no regression detection mechanism for now. Could you add tests for the core logic, which can be run-able without ROS-node spin?
sasakisasaki
added
the
run:build-and-test-differential
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13249 +/- ##
=======================================
Coverage 20.46% 20.46%
=======================================
Files 1949 1949
Lines 137092 137077 -15
Branches 48913 48909 -4
=======================================
- Hits 28051 28050 -1
+ Misses 86318 86305 -13
+ Partials 22723 22722 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…takagi/autoware_universe into feat/add-driving-mode-active-flag
sasakisasaki
approved these changes
Aug 26, 2026
sasakisasaki
left a comment
sasakisasaki
left a comment
Contributor
There was a problem hiding this comment.
Perhaps we can add tests for core logic. At this stage as the core logic is very small, I agree with merging this PR with the current files changed.
sasakisasaki
enabled auto-merge (squash)
August 26, 2026 12:11
github-project-automation
Bot
moved this from To Triage
to Done
in Software Working Group
TetsuKawa
pushed a commit
to TetsuKawa/autoware_universe
that referenced
this pull request
Sep 7, 2026
…13249) * feat(mrm_operator): add driving mode active flag Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * remove unnecessary conditions Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Junya Sasaki <junya.sasaki@tier4.jp> Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
TetsuKawa
pushed a commit
to TetsuKawa/autoware_universe
that referenced
this pull request
Sep 7, 2026
…13249) * feat(mrm_operator): add driving mode active flag Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * remove unnecessary conditions Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Junya Sasaki <junya.sasaki@tier4.jp>
TetsuKawa
pushed a commit
to TetsuKawa/autoware_universe
that referenced
this pull request
Sep 15, 2026
…13249) * feat(mrm_operator): add driving mode active flag Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * remove unnecessary conditions Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Junya Sasaki <junya.sasaki@tier4.jp>
shmpwk
pushed a commit
to shmpwk/pilot_auto_system-mirror
that referenced
this pull request
Sep 25, 2026
…autoware_universe#13249) * feat(mrm_operator): add driving mode active flag Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * remove unnecessary conditions Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Junya Sasaki <junya.sasaki@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add active flag for driving mode interface. This notifies that the output of the target mode is ready for actual use.
Related links
Parent Issue:
How was this PR tested?
The vehicle evaluation was performed with all PRs in #12497.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.