Repository navigation
feat(trajectory_modifier, minimum_rule_based_planner): improve obstacle stop feature - #13255
Merged
mkquda merged 5 commits intoAug 24, 2026
Merged
Conversation
…#3196) * fix stop wall appears behind ego Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * always publish modifier debug markers Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * fix extend_trajectory() function - use path curvature at end instead of relying on trajecory point orientations - for low end speed trajectory, default to straight extension Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * fix insert_stop_point logic to prevent wrong orientation stop pose Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * introduce minimum stop margin below which duplicate_check_threshold is ignored Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * handle zero stop_point_arc_length in insert_stop_point function Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp>
refactor obstacle stop utility function get_nearest_object_collision, update default param values Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp>
…bstacle stop (tier4#3234) * remove max_velocity_th param, fix collision check logic Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * tune rss params Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * apply pre-commit checks Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp>
…y type and shape (tier4#3255) * enable filtering objects by type and shape - update obstacle_stop params in modifier and backup planner to specify enabled types per shape - update surround_obstacle_stop params in modifier and backup planner to specify enabled types per shape - modify ObjectFilter code in obstacle_stop_utils to support filtering by type and shape - modify ObstacleProximityChecker class to support filtering by type and shape - fix ObstacleTracker logic for ignoring orientation change Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * Update planning/autoware_trajectory_modifier/include/autoware/trajectory_modifier/trajectory_modifier_utils/obstacle_stop_utils.hpp Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * apply pre-commit checks Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp>
mkquda
requested review from
Kotakku,
SakodaShintaro,
Sugar-98,
danielsanchezaran,
go-sakayori,
maxime-clem,
takayuki5168,
yuki-takagi-66 and
yukkysaito
as code owners
August 24, 2026 02:26
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
maxime-clem
approved these changes
Aug 24, 2026
Kotakku
approved these changes
Aug 24, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13255 +/- ##
==========================================
+ Coverage 20.31% 20.32% +0.01%
==========================================
Files 1951 1951
Lines 137034 137065 +31
Branches 48901 48922 +21
==========================================
+ Hits 27838 27864 +26
+ Misses 86640 86631 -9
- Partials 22556 22570 +14
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
paulsohn-github-app Bot
pushed a commit
to paulsohn/autoware_universe_planning_2
that referenced
this pull request
Aug 24, 2026
…le stop feature (autowarefoundation/autoware_universe#13255) * fix(trajectory_modifier): fix obstacle stop unstable stop wall (autowarefoundation/autoware_universe#3196) * fix stop wall appears behind ego Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * always publish modifier debug markers Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * fix extend_trajectory() function - use path curvature at end instead of relying on trajecory point orientations - for low end speed trajectory, default to straight extension Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * fix insert_stop_point logic to prevent wrong orientation stop pose Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * introduce minimum stop margin below which duplicate_check_threshold is ignored Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * handle zero stop_point_arc_length in insert_stop_point function Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * refactor(obstacle_stop): optimize collision check logic (autowarefoundation/autoware_universe#3024) refactor obstacle stop utility function get_nearest_object_collision, update default param values Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * feat(trajectory_modifier): remove max object velocity threshold for obstacle stop (autowarefoundation/autoware_universe#3234) * remove max_velocity_th param, fix collision check logic Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * tune rss params Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * apply pre-commit checks Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * feat(trajectory_modifier, backup_planner): enable filtering objects by type and shape (autowarefoundation/autoware_universe#3255) * enable filtering objects by type and shape - update obstacle_stop params in modifier and backup planner to specify enabled types per shape - update surround_obstacle_stop params in modifier and backup planner to specify enabled types per shape - modify ObjectFilter code in obstacle_stop_utils to support filtering by type and shape - modify ObstacleProximityChecker class to support filtering by type and shape - fix ObstacleTracker logic for ignoring orientation change Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * Update planning/autoware_trajectory_modifier/include/autoware/trajectory_modifier/trajectory_modifier_utils/obstacle_stop_utils.hpp Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * apply pre-commit checks Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * fix cherry-pick errors Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
TetsuKawa
pushed a commit
to TetsuKawa/autoware_universe
that referenced
this pull request
Sep 7, 2026
…le stop feature (autowarefoundation#13255) * fix(trajectory_modifier): fix obstacle stop unstable stop wall (autowarefoundation#3196) * fix stop wall appears behind ego Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * always publish modifier debug markers Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * fix extend_trajectory() function - use path curvature at end instead of relying on trajecory point orientations - for low end speed trajectory, default to straight extension Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * fix insert_stop_point logic to prevent wrong orientation stop pose Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * introduce minimum stop margin below which duplicate_check_threshold is ignored Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * handle zero stop_point_arc_length in insert_stop_point function Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * refactor(obstacle_stop): optimize collision check logic (autowarefoundation#3024) refactor obstacle stop utility function get_nearest_object_collision, update default param values Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * feat(trajectory_modifier): remove max object velocity threshold for obstacle stop (autowarefoundation#3234) * remove max_velocity_th param, fix collision check logic Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * tune rss params Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * apply pre-commit checks Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * feat(trajectory_modifier, backup_planner): enable filtering objects by type and shape (autowarefoundation#3255) * enable filtering objects by type and shape - update obstacle_stop params in modifier and backup planner to specify enabled types per shape - update surround_obstacle_stop params in modifier and backup planner to specify enabled types per shape - modify ObjectFilter code in obstacle_stop_utils to support filtering by type and shape - modify ObstacleProximityChecker class to support filtering by type and shape - fix ObstacleTracker logic for ignoring orientation change Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * Update planning/autoware_trajectory_modifier/include/autoware/trajectory_modifier/trajectory_modifier_utils/obstacle_stop_utils.hpp Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * apply pre-commit checks Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * fix cherry-pick errors Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
TetsuKawa
pushed a commit
to TetsuKawa/autoware_universe
that referenced
this pull request
Sep 7, 2026
…le stop feature (autowarefoundation#13255) * fix(trajectory_modifier): fix obstacle stop unstable stop wall (autowarefoundation#3196) * fix stop wall appears behind ego Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * always publish modifier debug markers Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * fix extend_trajectory() function - use path curvature at end instead of relying on trajecory point orientations - for low end speed trajectory, default to straight extension Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * fix insert_stop_point logic to prevent wrong orientation stop pose Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * introduce minimum stop margin below which duplicate_check_threshold is ignored Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * handle zero stop_point_arc_length in insert_stop_point function Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * refactor(obstacle_stop): optimize collision check logic (autowarefoundation#3024) refactor obstacle stop utility function get_nearest_object_collision, update default param values Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * feat(trajectory_modifier): remove max object velocity threshold for obstacle stop (autowarefoundation#3234) * remove max_velocity_th param, fix collision check logic Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * tune rss params Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * apply pre-commit checks Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * feat(trajectory_modifier, backup_planner): enable filtering objects by type and shape (autowarefoundation#3255) * enable filtering objects by type and shape - update obstacle_stop params in modifier and backup planner to specify enabled types per shape - update surround_obstacle_stop params in modifier and backup planner to specify enabled types per shape - modify ObjectFilter code in obstacle_stop_utils to support filtering by type and shape - modify ObstacleProximityChecker class to support filtering by type and shape - fix ObstacleTracker logic for ignoring orientation change Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * Update planning/autoware_trajectory_modifier/include/autoware/trajectory_modifier/trajectory_modifier_utils/obstacle_stop_utils.hpp Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * apply pre-commit checks Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * fix cherry-pick errors Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
shmpwk
pushed a commit
to tier4/pilot_auto_common
that referenced
this pull request
Sep 14, 2026
…le stop feature (autowarefoundation/autoware_universe#13255) * fix(trajectory_modifier): fix obstacle stop unstable stop wall (autowarefoundation/autoware_universe#3196) * fix stop wall appears behind ego Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * always publish modifier debug markers Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * fix extend_trajectory() function - use path curvature at end instead of relying on trajecory point orientations - for low end speed trajectory, default to straight extension Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * fix insert_stop_point logic to prevent wrong orientation stop pose Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * introduce minimum stop margin below which duplicate_check_threshold is ignored Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * handle zero stop_point_arc_length in insert_stop_point function Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * refactor(obstacle_stop): optimize collision check logic (autowarefoundation/autoware_universe#3024) refactor obstacle stop utility function get_nearest_object_collision, update default param values Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * feat(trajectory_modifier): remove max object velocity threshold for obstacle stop (autowarefoundation/autoware_universe#3234) * remove max_velocity_th param, fix collision check logic Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * tune rss params Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * apply pre-commit checks Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * feat(trajectory_modifier, backup_planner): enable filtering objects by type and shape (autowarefoundation/autoware_universe#3255) * enable filtering objects by type and shape - update obstacle_stop params in modifier and backup planner to specify enabled types per shape - update surround_obstacle_stop params in modifier and backup planner to specify enabled types per shape - modify ObjectFilter code in obstacle_stop_utils to support filtering by type and shape - modify ObstacleProximityChecker class to support filtering by type and shape - fix ObstacleTracker logic for ignoring orientation change Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * Update planning/autoware_trajectory_modifier/include/autoware/trajectory_modifier/trajectory_modifier_utils/obstacle_stop_utils.hpp Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * apply pre-commit checks Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * fix cherry-pick errors Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
TetsuKawa
pushed a commit
to TetsuKawa/autoware_universe
that referenced
this pull request
Sep 15, 2026
…le stop feature (autowarefoundation#13255) * fix(trajectory_modifier): fix obstacle stop unstable stop wall (autowarefoundation#3196) * fix stop wall appears behind ego Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * always publish modifier debug markers Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * fix extend_trajectory() function - use path curvature at end instead of relying on trajecory point orientations - for low end speed trajectory, default to straight extension Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * fix insert_stop_point logic to prevent wrong orientation stop pose Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * introduce minimum stop margin below which duplicate_check_threshold is ignored Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * handle zero stop_point_arc_length in insert_stop_point function Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * refactor(obstacle_stop): optimize collision check logic (autowarefoundation#3024) refactor obstacle stop utility function get_nearest_object_collision, update default param values Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * feat(trajectory_modifier): remove max object velocity threshold for obstacle stop (autowarefoundation#3234) * remove max_velocity_th param, fix collision check logic Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * tune rss params Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * apply pre-commit checks Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> * feat(trajectory_modifier, backup_planner): enable filtering objects by type and shape (autowarefoundation#3255) * enable filtering objects by type and shape - update obstacle_stop params in modifier and backup planner to specify enabled types per shape - update surround_obstacle_stop params in modifier and backup planner to specify enabled types per shape - modify ObjectFilter code in obstacle_stop_utils to support filtering by type and shape - modify ObstacleProximityChecker class to support filtering by type and shape - fix ObstacleTracker logic for ignoring orientation change Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> * Update planning/autoware_trajectory_modifier/include/autoware/trajectory_modifier/trajectory_modifier_utils/obstacle_stop_utils.hpp Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * apply pre-commit checks Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * fix cherry-pick errors Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> --------- Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp> Signed-off-by: Mohammad Alqudah <alqudah.mohammad@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR applies the following improvements to
obstacle_stopfeature used intrajectory_modifierandminimum_rule_based_planner:get_nearest_object_collisionto optimize collision checkextend_trajectory()functioninsert_stop_pointlogic to prevent wrong orientation stop poseduplicate_check_thresholdis ignoredAdditionally it updates the logic of
obstacle_stopandsurround_obstacle_stopto enable filtering by type and shape:obstacle_stopparams in modifier and backup planner to specify enabled types per shapesurround_obstacle_stopparams in modifier and backup planner to specify enabled types per shapeObjectFiltercode inobstacle_stop_utilsto support filtering by type and shapeObstacleProximityCheckerclass to support filtering by type and shapeObstacleTrackerlogic for ignoring orientation changeRelated links
How was this PR tested?
Notes for reviewers
None.
Interface changes
objects.object_typesobjects.target_objects.bboxobjects.target_objects.polygonsurround_obstacle_stop.object_typessurround_obstacle_stop.target_objects.bboxsurround_obstacle_stop.target_objects.polygonNone.
Effects on system behavior