Repository navigation
feat(autoware_diffusion_planner): persist model load errors on inference_status - #13388
Merged
Owen-Liuyuxuan merged 1 commit intoOct 13, 2026
Conversation
…nce_status Keep the original TensorRT/ONNX load exception on inference_status instead of replacing it with a generic message on each planning tick. Add model path key-values for easier Foxglove and diagnostics triage. Migrated from tier4#3391 (diffusion planner scope only). Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Owen-Liuyuxuan
requested review from
SakodaShintaro,
danielsanchezaran,
go-sakayori,
yhisaki and
yukkysaito
as code owners
September 13, 2026 23:47
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
SakodaShintaro
approved these changes
Sep 14, 2026
SakodaShintaro
left a comment
Contributor
There was a problem hiding this comment.
I conformed that psim normally works.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13388 +/- ##
==========================================
- Coverage 20.67% 20.67% -0.01%
==========================================
Files 1951 1951
Lines 137663 137688 +25
Branches 49703 49723 +20
==========================================
Hits 28466 28466
- Misses 86246 86270 +24
- Partials 22951 22952 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owen-Liuyuxuan
merged commit Oct 13, 2026
e0c3bec
into
autowarefoundation:main
42 of 44 checks passed
paulsohn-github-app Bot
pushed a commit
to paulsohn/autoware_universe_planning_2
that referenced
this pull request
Oct 13, 2026
…nce_status (autowarefoundation/autoware_universe#13388) Keep the original TensorRT/ONNX load exception on inference_status instead of replacing it with a generic message on each planning tick. Add model path key-values for easier Foxglove and diagnostics triage. Migrated from tier4/autoware_universeautowarefoundation/autoware_universe#3391 (diffusion planner scope only). Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com> Co-authored-by: Cursor <cursoragent@cursor.com>
shmpwk
pushed a commit
to tier4/pilot_auto_planning
that referenced
this pull request
Oct 14, 2026
…nce_status (autowarefoundation/autoware_universe#13388) Keep the original TensorRT/ONNX load exception on inference_status instead of replacing it with a generic message on each planning tick. Add model path key-values for easier Foxglove and diagnostics triage. Migrated from tier4/autoware_universeautowarefoundation/autoware_universe#3391 (diffusion planner scope only). Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inference_statusand republish it every planning tick instead of overwriting with"Model not loaded".backend,model_type,model_loaded, and resolved model path key-values toinference_statusfor easier triage in Foxglove and/diagnostics.fill_model_key_values()andpublish_inference_status()soDiagnosticsInterface::clear()does not drop key-values unexpectedly.Ported from tier4/autoware_universe#3391 (diffusion planner scope only; no
ml_plannerortrajectory_processorchanges).Test plan
colcon build --packages-select autoware_diffusion_plannerinference_statusERROR message shows the load exception text (not only"Model not loaded")inference_statusOK with model path key-values on timer ticksMade with Cursor