Skip to content

feat(autoware_diffusion_planner): persist model load errors on inference_status - #13388

Merged
Owen-Liuyuxuan merged 1 commit into
autowarefoundation:mainfrom
Owen-Liuyuxuan:feat/diffusion-planner-persist-inference-status
Oct 13, 2026
Merged

Owen-Liuyuxuan merged 1 commit into
autowarefoundation:mainfrom
Owen-Liuyuxuan:feat/diffusion-planner-persist-inference-status

Conversation

@Owen-Liuyuxuan

Copy link
Copy Markdown
Contributor

Summary

  • Persist the original TensorRT/ONNX model load exception on inference_status and republish it every planning tick instead of overwriting with "Model not loaded".
  • Add backend, model_type, model_loaded, and resolved model path key-values to inference_status for easier triage in Foxglove and /diagnostics.
  • Refactor load/publish paths through fill_model_key_values() and publish_inference_status() so DiagnosticsInterface::clear() does not drop key-values unexpectedly.

Ported from tier4/autoware_universe#3391 (diffusion planner scope only; no ml_planner or trajectory_processor changes).

Test plan

  • colcon build --packages-select autoware_diffusion_planner
  • Launch with invalid/missing model paths and confirm inference_status ERROR message shows the load exception text (not only "Model not loaded")
  • Successful load: inference_status OK with model path key-values on timer ticks

Made with Cursor

…nce_status

Keep the original TensorRT/ONNX load exception on inference_status instead of
replacing it with a generic message on each planning tick. Add model path
key-values for easier Foxglove and diagnostics triage.

Migrated from tier4#3391 (diffusion planner scope only).

Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 13, 2026
@github-actions

Copy link
Copy Markdown

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@SakodaShintaro SakodaShintaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I conformed that psim normally works.

@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 14, 2026
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.67%. Comparing base (a79d071) to head (b9223cb).

Files with missing lines Patch % Lines
...e_diffusion_planner/src/diffusion_planner_node.cpp 0.00% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13388      +/-   ##
==========================================
- Coverage   20.67%   20.67%   -0.01%     
==========================================
  Files        1951     1951              
  Lines      137663   137688      +25     
  Branches    49703    49723      +20     
==========================================
  Hits        28466    28466              
- Misses      86246    86270      +24     
- Partials    22951    22952       +1     
Flag Coverage Δ *Carryforward flag
full-suite 20.67% <ø> (+<0.01%) ⬆️ Carriedforward from a79d071

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Owen-Liuyuxuan
Owen-Liuyuxuan merged commit e0c3bec into autowarefoundation:main Oct 13, 2026
42 of 44 checks passed
@github-project-automation github-project-automation Bot moved this from To Triage to Done in Software Working Group Oct 13, 2026
paulsohn-github-app Bot pushed a commit to paulsohn/autoware_universe_planning_2 that referenced this pull request Oct 13, 2026
…nce_status (autowarefoundation/autoware_universe#13388)

Keep the original TensorRT/ONNX load exception on inference_status instead of
replacing it with a generic message on each planning tick. Add model path
key-values for easier Foxglove and diagnostics triage.

Migrated from tier4/autoware_universeautowarefoundation/autoware_universe#3391 (diffusion planner scope only).

Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
shmpwk pushed a commit to tier4/pilot_auto_planning that referenced this pull request Oct 14, 2026
…nce_status (autowarefoundation/autoware_universe#13388)

Keep the original TensorRT/ONNX load exception on inference_status instead of
replacing it with a generic message on each planning tick. Add model path
key-values for easier Foxglove and diagnostics triage.

Migrated from tier4/autoware_universeautowarefoundation/autoware_universe#3391 (diffusion planner scope only).

Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants