Repository navigation
docs(autoware_traffic_light_visualization): correct the ROI inputs and the missing parameter - #13474
Merged
kentdotn merged 2 commits intoOct 13, 2026
Conversation
…ly feeds each ROI input The README named the fine detector as the source of ~/input/rois, but that is true in only one of the three detection chains autoware_launch ships. traffic_light_detector_rough.launch.xml feeds the map based detector's ROIs straight into ~/input/rois, and traffic_light_detector_whole_image.launch .xml feeds the selector's. What is actually constant is the shape of the wiring: ~/input/rois is the last stage of the chain and ~/input/rough/rois is the stage before it, connected only when there is one - which is also when use_high_accuracy_detection is true. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Kentaro NAGATOMO <kentaro.nagatomo@tier4.jp>
…er parameters that were missing use_high_accuracy_detection is declared without a default, so the node refuses to start unless it is given, yet neither the parameter file nor the schema mentioned it - only the launch file did. List it in both, with the value the launch file already defaults to, and drop the [[maybe_unused]] on image_roi_callback's traffic signal argument, which the callback does use. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Kentaro NAGATOMO <kentaro.nagatomo@tier4.jp>
github-actions
Bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kentdotn
added
the
run:build-and-test-differential
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13474 +/- ##
==========================================
- Coverage 37.57% 37.56% -0.01%
==========================================
Files 2025 2025
Lines 141921 141921
==========================================
- Hits 53320 53319 -1
- Misses 88601 88602 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sasakisasaki
approved these changes
Oct 9, 2026
sasakisasaki
left a comment
sasakisasaki
left a comment
Contributor
There was a problem hiding this comment.
Thank you for updating the document. Let me approve this PR 👍
interimadd
approved these changes
Oct 13, 2026
kentdotn
marked this pull request as ready for review
October 13, 2026 01:57
kentdotn
requested review from
MasatoSaeki,
a-maumau,
technolojin,
tzhong518 and
yukkysaito
as code owners
October 13, 2026 01:57
a-maumau
approved these changes
Oct 13, 2026
github-project-automation
Bot
moved this from To Triage
to Done
in Software Working Group
This was referenced Oct 13, 2026
kentdotn
deleted the
docs/traffic-light-roi-visualizer-inputs-and-parameters
branch
October 19, 2026 09:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Purpose
Three corrections found while separating the drawing from the node, kept out of that PR because none of them had to happen before the move. Nothing observable changes, and the whole diff is 14 lines, so it reads in one go rather than commit by commit.
What is corrected
The README named the wrong source for
~/input/rois. It saidautoware_traffic_light_fine_detector, which is right in one of the three detection chains autoware_launch ships.traffic_light_detector_rough.launch.xmlfeeds that topic from the map based detector, andtraffic_light_detector_whole_image.launch.xmlfrom the selector. What is constant is the shape of the wiring:~/input/roisis the last stage of the chain and~/input/rough/roisthe stage before it, connected only when there is one - which is also whenuse_high_accuracy_detectionis true.use_high_accuracy_detectionwas missing from the parameter file and the schema. It is declared without a default, so the node refuses to start unless it is given, yet only the launch file mentioned it. Both now list it, with the value the launch file already defaults to.image_roi_callback()had a[[maybe_unused]]on an argument it does use. Dropped.Related links
Parent Issue:
Builds on #13454, now merged, so this sits on
main.How was this PR tested?
From the CI-equivalent dev container (
ghcr.io/autowarefoundation/autoware:universe-dependencies-jazzy):colcon build --packages-select autoware_traffic_light_visualization \ --cmake-args -DCMAKE_BUILD_TYPE=RelWithDebInfo colcon test --packages-select autoware_traffic_light_visualization \ --event-handlers console_direct+pre-commitpasses, including the JSON schema validation the schema change touches.Notes for reviewers
Interface changes
None. The parameter was already required; it is now documented.
Effects on system behavior
None.
🤖 Generated with Claude Code