Skip to content

Conversation

@allyoucanmap
Copy link
Contributor

@allyoucanmap allyoucanmap commented Feb 27, 2025

Description

This PR includes missing logic for tags in resource creation workflow

see #10857 (comment)

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

#10857

What is the new behavior?

Tags are saved for new resources

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@allyoucanmap allyoucanmap added this to the 2025.01.00 milestone Feb 27, 2025
@allyoucanmap allyoucanmap self-assigned this Feb 27, 2025
@allyoucanmap allyoucanmap linked an issue Feb 27, 2025 that may be closed by this pull request
1 task
@allyoucanmap allyoucanmap requested a review from dsuren1 February 27, 2025 14:50
@dsuren1 dsuren1 merged commit 4067d76 into geosolutions-it:master Feb 28, 2025
6 checks passed
@dsuren1
Copy link
Contributor

dsuren1 commented Feb 28, 2025

@ElenaGallo Kindly test it in DEV, when available. Thanks!

rmelarab-ngs added a commit to ngsllc/MapStore2 that referenced this pull request Apr 1, 2025
* Update LICENSE.txt

* geosolutions-it#10236: Fix - Legend filter incompatibility with style editing (geosolutions-it#10742)

* Fix geosolutions-it#10592 cesium/3d mode forces wms requests to version 1.1.1

* geosolutions-it#10719: enable upload images within Text widgets (geosolutions-it#10735)

* geosolutions-it#10719: enable upload images within Text widgets
Description:
- add 'prop' called 'enableUploadImg' passing it to 'CompactRichTextEditor' component to enable upload image
- add unit test

* geosolutions-it#10719: revert naming enableUploadImg to be uploadEnabled

* fix:proxy call for CORS disabled domain for Model layer (geosolutions-it#10745)

* Fix geosolutions-it#10709 Allow to set the CESIUM_BASE_URL dynamically (geosolutions-it#10710)

* Fix geosolutions-it#10633 Enhancing MapViews Layer Options (geosolutions-it#10747)

* Fix geosolutions-it#10633 Enhancing MapViews Layer Options

* review changes

* Update tomcat base image (geosolutions-it#10682)

Solve many security warning on external components. Fixes geosolutions-it#10476

* dashboardSave should use floppy-disk to distinguish it from dashboardSaveAs (geosolutions-it#10644)

* fix: Set column label in feature grid through customizeAttribute (geosolutions-it#10638)

* Fix geosolutions-it#10768 SearchServicesConfig was not updating state correctly (geosolutions-it#10769)

* geosolutions-it#10766: Remove error notified by GeoFence when moving a rule for geofence stand-alone version only (geosolutions-it#10767)

Description:
- fixing the shown error by moving the RULE_SAVED action to be after move rule in case full update and throw error only if addRule is failed

* geosolutions-it#10753: Improve the way group names are visualized in user settings by showing tooltip for selected items (geosolutions-it#10757)

* geosolutions-it#10753: Improve the way group names are visualized in user settings by showing tooltip for selected items

* geosolutions-it#10753: add helpful comment for valueRenderer prop in Select of react-select

* geosolutions-it#10753: Improve the way group names are visualized in user settings by showing tooltip for selected items (resolve review comments)
- remove unused comment for import + edit a typo mistake in a comment in UserGroups.jsx

* geosolutions-it#10750: CRSs supported in vector import (geosolutions-it#10751)

* geosolutions-it#10750: clarify the formats that stricktly require 4326 in import vector layers
Description:
- edit translations

* geosolutions-it#10750: remove unnecessary space in translations

* [profiletool] fix importing geojson files on firefox on linux (geosolutions-it#9912) (geosolutions-it#9913)

Fix geosolutions-it#9912 for some reason mimetype is detected as application/geo+json

* geosolutions-it#10736: Interactive legend for TOC layers [WFS Layer part] (geosolutions-it#10748)

* Addressing build issue by changing antrun task to target (geosolutions-it#10777)

* Authkey is currently not sent for WMS GetLegendGraphic requests geosolutions-it#10727 (geosolutions-it#10765)

* added authkey parameters in secure image

* fix: use query-string, add test

* Fix geosolutions-it#10631 New MapStore Home Page (geosolutions-it#10731)

* Fix geosolutions-it#10631 New MapStore Home Page

* fix translations

* setup tests for components

* review resources catalog plugins export

* review resource card information

* review changes

* add comment on all deprecated plugins

* migrate context configuration

* geostore update

* introduce groups filter

* Addressing build issue by changing antrun task to target

* fix select filter field search queries

* review plugin positions to fix context burger menu

* fix import/export screen

---------

Co-authored-by: Tobia Di Pisa <tobia.dipisa@geosolutionsgroup.com>

* Update upload-artifact and cache github action to most recent versions (geosolutions-it#10790)

* Update upload-artifact action

* Updated cache actions to v4

* Fixed set-output warning

* Query parameter documentation update (geosolutions-it#10791)

* Query parameter documentation update

* align

* link to app context

* correct link

* Update docs/developer-guide/map-query-parameters.md

---------

Co-authored-by: Tobia Di Pisa <tobia.dipisa@geosolutionsgroup.com>

* geosolutions-it#10787: add missing documentation part related to interactive legend for wfs layer (geosolutions-it#10788)

* Fix geosolutions-it#10783 Support for favorites (geosolutions-it#10795)


---------

Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>

* geosolutions-it#10736: fix issue of not hiding the enabled/disabled filter icon in case there is no filters after reseting the interactive legend (geosolutions-it#10797)

* Fix geosolutions-it#10782 Support for Tags (geosolutions-it#10796)


---------

Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>

* Fix geosolutions-it#10781 Review pluginsConfig after introduction of new homepage plugins (geosolutions-it#10800)

* geosolutions-it#10770: Vector files import limits (geosolutions-it#10772)

* geosolutions-it#10770: Vector files import limits
Description:
- handle checking the file size for imported vector layers only
- show a warning notification for each layer has size larger than the configurable limit if configured
- add translations
- add test units

* geosolutions-it#10770: Vector files import limits
Description:
- add enhancements to the code including some helpful comments

* geosolutions-it#10770: Vector files import limits
Description:
- rename the configurable prop name of vector max size to 'importedVectorFileMaxSizeInMB' instead of 'importedVectorFileSizeInMB' to be more meaningful

* geosolutions-it#10770: Vector files import limits
Description:
- replace using 'getConfigProp' for 'importedVectorFileMaxSizeInMB' with direct cfg  to map import
- modify files based on this change
- put default max file size with 2 mega byte

* geosolutions-it#10770: Vector files import limits
Description:
- edit unit tests of processFiles due to changes to fix FE test failures

* geosolutions-it#10770: Vector files import limits
Description:
- update max file size to be 3 mb instead of only 2

* geosolutions-it#10770: Vector files import limits
Description:
- replace fixed max file size in useFiles with the constant 'DEFAULT_VECTOR_FILE_MAX_SIZE_IN_MB' instead

* geosolutions-it#10637: fix Longitudinal profil does not close properly and it leads to conflicts between the longitudinal profil and measure plugin (geosolutions-it#10806)

* geosolutions-it#10637: fix Longitudinal profil does not close properly and it leads to conflicts between the longitudinal profil and measure plugin
Description:
- fix issue of draw conflicts between longitudinal profil and measure plugin in longitudinalProfile epic by reset drawing in 'LPonDockClosedEpic'
- add unit test

* geosolutions-it#10637: add drawOwner selector
Description:
- add drawOwner selector to be used in 'LPonDockClosedEpic'
- add unit test

* geosolutions-it#10758: Support for Cesium Ion Terrain Provider (geosolutions-it#10763)

* Update memory heap by using build args instead of runtime args (geosolutions-it#10802)

* geosolutions-it#10005 update babel configuration (geosolutions-it#10006)

* Fix geosolutions-it#10005 update babel configuration

* Update utility/eslint/package.json

* Fix geosolutions-it#10005 update babel configuration

* Update utility/eslint/package.json

* Fixed svg rule

* Delete checkVersion.sh

* Fixed eslint error

* geosolutions-it#10816: Allow dynamic management of style editing permissions (geosolutions-it#10821)

* Fix geosolutions-it#10812 excluding fixed list of layers (geosolutions-it#10815)

* Fix geosolutions-it#10807 updating view also when center prop is changing (geosolutions-it#10808)

* Fix geosolutions-it#10807 updating view also when center prop is changing

* updated code using isNearlyEqual for center comparison

* update code for lint issues

* fix test

* Fix geosolutions-it#10754 add option for not using UTC for date formats in FeatureEditor (geosolutions-it#10760)

* Fix geosolutions-it#10754 add option for not using UTC for date formats in FeatureEditor

* tentative for fixing test

* fix lint

* removing test

* fix test

* geosolutions-it#10799: Cesium map dark when opened in the evening (geosolutions-it#10803)

* Layer download fails when layer attributes are changed in feature grid geosolutions-it#10597 (geosolutions-it#10832)

* geosolutions-it#10825: Fix - Unnecessary re-rendering of the resource plugin (geosolutions-it#10833)

* geosolutions-it#10737: Interactive legend for TOC layers [Vector Layer part] (geosolutions-it#10798)



---------

Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>

* Fix geosolutions-it#10805 JAXBException while updating an existing dashboard (geosolutions-it#10813)


---------

Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>

* Revert "Fix geosolutions-it#10807 updating view also when center prop is changing (geosolutions-it#10808)" (geosolutions-it#10840)

This reverts commit 3fedb7f.

* Fix geosolutions-it#10776 Review the open properties icon and the order of item in the viewer navbar (geosolutions-it#10827)

* Fix geosolutions-it#10824 Adjust placement of Search and TOC button (geosolutions-it#10828)

* Fix geosolutions-it#10786 Review of the home description image (geosolutions-it#10823)

* Fix geosolutions-it#10785 Review of footer plugin (geosolutions-it#10822)



---------

Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>

* Fix geosolutions-it#10848 Align height of resource cards (geosolutions-it#10849)

* Fix geosolutions-it#10778 Dev guide, JSDoc and migration documentation for the new homepage plugins (geosolutions-it#10814)

* Fix geosolutions-it#9365 Add JSON file formatting (geosolutions-it#10830)

* Fix geosolutions-it#10824 Adjust placement of Map Views plugin (geosolutions-it#10861)

* Fix geosolutions-it#10853 Context Card buttons issue (geosolutions-it#10864)

* Fix geosolutions-it#10830 eol LF for json files (geosolutions-it#10873)

* Fix geosolutions-it#10852 Edit properties button for Anonymuos user (geosolutions-it#10863)

* Fix geosolutions-it#10858 Properties panel from a new GeoStory (geosolutions-it#10871)

* Fix geosolutions-it#10858 Properties panel from a new GeoStory

* fix json formatting

* Fix geosolutions-it#10857 There is the Edit properties from an unsaved resource option (geosolutions-it#10870)

* Fix geosolutions-it#10854 Homepage - Issues on Tooltips (geosolutions-it#10869)

* Fix geosolutions-it#10854 Homepage - Issues on Tooltips

* fix failing tests

* remove useEffect mock in tests

* Fix geosolutions-it#10804 Prevent creation of duplicate tags (geosolutions-it#10850)

* geosolutions-it#10826: Fix - URL aliases ignored on added layers (geosolutions-it#10843)

* geosolutions-it#10829: Fix - Issue creating Circle annotation with form radius (geosolutions-it#10845)

* Fix geosolutions-it#10862 Manage Access Rules issue with new Navigation bar (geosolutions-it#10877)

* Fix geosolutions-it#10862 Manage Access Rules issue with new Navigation bar

* update jsdoc

* Update docs/developer-guide/mapstore-migration-guide.md

---------

Co-authored-by: Suren <dsuren1@gmail.com>

* Fix geosolutions-it#10859 Share button on new dashbaord (geosolutions-it#10879)

* Fix geosolutions-it#10878 adding mergeableParams params (geosolutions-it#10883)

* Fix geosolutions-it#10878 adding mergeableParams params

* Update web/client/utils/PrintUtils.js

---------

Co-authored-by: Suren <dsuren1@gmail.com>

* geosolutions-it#10825: Fix - Duplicate locale and resource request after saving a context (geosolutions-it#10868)

* geosolutions-it#10825: Fix - Duplicate locale and resource request after saving a context

* update unit tests

* geosolutions-it#10867: Fix - Saving context loads duplicate extensions as scripts (geosolutions-it#10872)

* Fix geosolutions-it#10884 Permissions already present on a resource are no longer visible if the properties edit starts from the info tab (geosolutions-it#10885)

* Fix geosolutions-it#10857 add tags on new resources (geosolutions-it#10887)

* Fix geosolutions-it#10856 GeoStory - The Share button is not present (geosolutions-it#10888)

* Fix geosolutions-it#10779 Remove unused code related to homepage (geosolutions-it#10889)

* Fix geosolutions-it#10779 Remove unused code related to homepage

* fix documentation

* jsdoc update

* Fix geosolutions-it#10855 Show as modal and Show as startup Details issue (geosolutions-it#10886)

* Fix geosolutions-it#10855 Show as modal and Show as startup Details issue

* fix resource details reload in viewer

* Fix geosolutions-it#10778 add db migration scripts (geosolutions-it#10892)

* Fix geosolutions-it#10890 Error when timeline and widgets plugins are enabled at same time (geosolutions-it#10891)

* Enhancing User Session geosolutions-it#10657 (geosolutions-it#10712)

* Fix geosolutions-it#10893 Making sure scripts from extensions are not cached (geosolutions-it#10895)

* Fix geosolutions-it#10893 Making sure scripts from extensions are not cached

* update loadPlugin

---------

Co-authored-by: Suren <dsuren1@gmail.com>

* Fix geosolutions-it#10894 Persist resources gird previous filters on navigation (geosolutions-it#10896)

* Bump versions on master for release-branch (geosolutions-it#10904)

Co-authored-by: github-actions <github-actions@github.com>

* geosolutions-it#10902: Support for configuring editing of default style of the layer (geosolutions-it#10903)

* geosolutions-it#10902: Support for configuring editing of default style of the layer

* jsdoc updated

* updated default props

* update unit tests

* code refactor and update unit tests

* Bump jinja2 from 3.1.4 to 3.1.6 in /docs (geosolutions-it#10907)

Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.6.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.4...3.1.6)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Improved LDAP and coproprate proxy configurations documentation (geosolutions-it#10906)

* Fix geosolutions-it#5822 improve ldap documentation

* Improved LDAP documntation

* Documented also http.proxyHost and other java props

* restore old ldap properties

* restore old ldap properties

* Apply suggestions from code review

Co-authored-by: Tobia Di Pisa <tobia.dipisa@geosolutionsgroup.com>

* Apply suggestions from code review

Co-authored-by: Tobia Di Pisa <tobia.dipisa@geosolutionsgroup.com>

* Apply suggestions from code review

* Fixed to relative URL the requirements link

---------

Co-authored-by: Tobia Di Pisa <tobia.dipisa@geosolutionsgroup.com>

* geosolutions-it#10831: Improve how printing map preview is managed (geosolutions-it#10866)

* geosolutions-it#10831: Improve how printing map preview is managed
Description:
- handling printing map preview is no longer synchronized with the viewer's map
- handling printing map preview can be moved and zoomed independently using the mouse wheel and/or the scale selector, if present
- enable the user to click on print, the final print will in fact use the center and scale (properly converted) on the map preview, with the result of printing the same viewport (the image may change in resolution because of the DPI selector)
- handling sync button in the preview map just for manually synching the preview with the viewer's map remain available as is (if configured)
- add unit test

* geosolutions-it#10831: Improve how printing map preview is managed
Description:
- in Print plugin, for mapPreviewOptions prop --> set 'enableRefresh' with true as a default value

* Fix geosolutions-it#10880 Test run failing locally (geosolutions-it#10882)

* Fix geosolutions-it#10835 load map error and correctly update view when sharing a map (geosolutions-it#10847)

* fix: Improve build.sh to pass shelcheck (geosolutions-it#10811)

* fix: Improve build.sh to pass shelcheck

* Use new version scheme on build.sh example

---------

Co-authored-by: Joan <joan.juvanteny@bassolsenergia.com>

* Fix geosolutions-it#10912 by making dialog opening to the left of the image button (geosolutions-it#10920)

* Fix geosolutions-it#10912 by making dialog opening to the left of the image button

* Fixed position for widgets

* Update web/client/themes/default/less/common.less

---------

Co-authored-by: Suren <dsuren1@gmail.com>

* geosolutions-it#10918: Fix issue with measure tool in Cesium map (geosolutions-it#10933)

* Fix geosolutions-it#10818 Review and uniform all confirmation modals according to a common design. (geosolutions-it#10851)

* Fix geosolutions-it#10899 About Plugin content  (geosolutions-it#10921)

* Fix: Changes in about content

* fixed : typo

* Update web/client/translations/data.it-IT.json

---------

Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>

* Fix geosolutions-it#10910 search bar overlap gfi panel (geosolutions-it#10913)

* Fix geosolutions-it#10910 search bar overlap gfi panel

* improving selectors

* Fix issue in wrongly overriding context user plugins

* Update web/client/epics/identify.js

Co-authored-by: Suren <dsuren1@gmail.com>

* Update web/client/reducers/context.js

Co-authored-by: Suren <dsuren1@gmail.com>

* Update web/client/reducers/context.js

Co-authored-by: Suren <dsuren1@gmail.com>

* Update web/client/reducers/context.js

Co-authored-by: Suren <dsuren1@gmail.com>

* fix lint and revert

---------

Co-authored-by: Suren <dsuren1@gmail.com>

* geosolutions-it#10937: Unable to visualize some 3D tiles data in MapStore (geosolutions-it#10948)

Description:
- Handle a spacial case for import csw 3dtile layer with array of URI by extracting the 1st valid uri ending with .json
- add unit tests

* geosolutions-it#10940 (geosolutions-it#10941)

Fix incorrect layer usage in widget opened from feature grid
- changed selector for layer when new chart created from feature grid
- Updated and added relevant tests

On behalf of DB Systel GmbH

Co-authored-by: CongChen <cong.chen.mz@gmail.com>

* Fix geosolutions-it#10914 - Fixed WPS wrong parsing of GetExecutionStatus result (geosolutions-it#10915)

* Fix geosolutions-it#10897 Moved about in BrandNavBar and is now visible in all app pages. (geosolutions-it#10909)

* Add catalan translation (geosolutions-it#10932)

* Add catalan translation

* Fix json format

* Increased suppported langs test

* Fix locale name

---------

Co-authored-by: Joan <joan.juvanteny@bassolsenergia.com>

* geosolutions-it#10961: Fix - Styleeditor not working with only two available styles (geosolutions-it#10964)

* geosolutions-it#10961: Fix - Styleeditor not working with only two available styles

* remove console

* Fix geosolutions-it#10898 Move viewer language selector in Brand Navbar as is for all other app pages (geosolutions-it#10908)

* Fix  geosolutions-it#10899 about section content  (geosolutions-it#10946)

* geosolutions-it#10936: Add resource name in the window title of the browser (geosolutions-it#10955)

* geosolutions-it#10936: Add resource name in the window title of the browser
Description:
- handle edit document title in case open different resources: maps, dashboards, geostories
- add unit tests

* geosolutions-it#10936: Add resource name in the window title of the browser
Description:
- handle showing directly map name instead of passing by the context name in case of a map opened and based on a context
- when opening context resources it will show resource name i.e. context name
- add missing jsdocs

* geosolutions-it#10936: Add resource name in the window title of the browser
Description:
- add a unit test for 'mapNameSelector' in 'map/selector'

* Updated icons and port for devServer.js file and pom.xml

* Updated db properties for dev environment

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Simone Giannecchini <simboss1@gmail.com>
Co-authored-by: Suren <dsuren1@gmail.com>
Co-authored-by: Landry Breuil <landryb@users.noreply.github.com>
Co-authored-by: mahmoud adel <58145645+mahmoudadel54@users.noreply.github.com>
Co-authored-by: RowHeat <40065760+rowheat02@users.noreply.github.com>
Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>
Co-authored-by: Lior Kaplan <lior@kaplanopensource.co.il>
Co-authored-by: Thomas Hallundbæk <72447095+tha-nordiq@users.noreply.github.com>
Co-authored-by: Jonathan Durand <38976316+jdugh@users.noreply.github.com>
Co-authored-by: Matteo V. <matteo.velludini@geosolutionsgroup.com>
Co-authored-by: Tobia Di Pisa <tobia.dipisa@geosolutionsgroup.com>
Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
Co-authored-by: boukandouramhamed <boukandouramhamed@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: aseques <aseques@gmail.com>
Co-authored-by: Joan <joan.juvanteny@bassolsenergia.com>
Co-authored-by: Anup Dahal <adahal39@gmail.com>
Co-authored-by: congchen1101 <161452326+congchen1101@users.noreply.github.com>
Co-authored-by: CongChen <cong.chen.mz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is the Edit properties from an unsaved resource option

2 participants