Closed
Conversation
curious what would happen
[skip ci] Co-Authored-By: Max Duval <hi@mxdvl.com> Co-Authored-By: Charlotte Emms <43961396+cemms1@users.noreply.github.com> Co-Authored-By: Jamie B <53781962+JamieB-gu@users.noreply.github.com>
Co-Authored-By: Max Duval <hi@mxdvl.com> Co-Authored-By: Charlotte Emms <43961396+cemms1@users.noreply.github.com> Co-Authored-By: Jamie B <53781962+JamieB-gu@users.noreply.github.com>
cemms1
changed the title
|
Size Change: 0 B Total Size: 1.41 MB ℹ️ View Unchanged
|
cemms1
force-pushed
the
rename-infra-stacks
branch
3 times, most recently
from
a0e2c42 to
b662f95
Compare
cemms1
force-pushed
the
rename-infra-stacks
branch
from
b662f95 to
a0c975d
Compare
cemms1
commented
Nov 3, 2023
| cloudFormationStackName: article-rendering | ||
| amiParameter: AMIArticlerendering | ||
| article-rendering: | ||
| cloudFormationStackName: rendering |
Contributor
Author
|
Why is the cloudformation stack called |
cemms1
force-pushed
the
rename-infra-stacks
branch
2 times, most recently
from
60ecbfc to
3ba7b6d
Compare
abeddow91
reviewed
Nov 6, 2023
cemms1
force-pushed
the
rename-infra-stacks
branch
from
3ba7b6d to
1f76422
Compare
cemms1
changed the title
cemms1
commented
Nov 6, 2023
| } satisfies Alarms) | ||
| : ({ noMonitoring: true } satisfies NoMonitoring); | ||
|
|
||
| new GuEc2App(this, { |
Contributor
Author
There was a problem hiding this comment.
should we use GuNodeApp instead?
Comment on lines
+60
to
+61
| // TODO - should we change to 3000? | ||
| applicationPort: 9000, |
Contributor
Author
There was a problem hiding this comment.
Should we look into changing the port of the application?
Comment on lines
+72
to
+76
| certificateProps: { | ||
| domainName: `${app}-${stack}.${ | ||
| stage === 'PROD' ? '' : 'code.dev-' | ||
| }gutools.co.uk`, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
do we definitely need a certificate?
Contributor
There was a problem hiding this comment.
We discovered that this was necessary for the creation of a listener on port 443, instead of the default 8080 which was unreachable.
Closed
Contributor
Author
|
We can test frontend > DCR by updating the value of the SSM param referenced here https://github.com/guardian/frontend/blob/main/common/app/common/configuration.scala#L152 |
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
|
This PR was closed because it has been stalled for 3 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Using GuCDK Patterns for building our service
Reduce the amount of custom configuration and benefit from consistency with other Guardian AWS projects.
This trials using the set pattern for a EC2 app as provided by GuCDK, replacing the existing bespoke constructs and letting GuCDK make most of the decisions.
Reorganising WebX’s apps and stacks
It also trials a new naming strategy for Riffraff stacks, Cloudformation stacks, and GuCDK stacks and apps.
Add new apps in the DCR stack
We choose to follow Option 1 in #8351.
The new stack structure will look like the following:
where the
frontendanddotcom-renderingare stacks in the Guardian sense, which contains a collection of Guardian apps (e.g. article, fronts, sport, archive, …) which together make up a cohesive service (e.g. Ophan, frontend, MAPI, …)In Riffraff, we can deploy
dotcom-rendering:allto deploy all of our rendering apps (article-web, article-apps, etc). This follows the current naming convention offrontend:allwhich deploys all "frontend" apps.Why?
Resolves #9374
Task before this can be deployed