Add new article stack using GuEc2App pattern for dual stack migration#9955
Merged
Add new article stack using GuEc2App pattern for dual stack migration#9955
Conversation
|
Size Change: 0 B Total Size: 741 kB ℹ️ View Unchanged
|
cemms1
changed the title
cemms1
force-pushed
the
use-cdk-pattern
branch
2 times, most recently
from
9c071e7 to
9216ddf
Compare
cemms1
commented
Dec 20, 2023
cemms1
force-pushed
the
use-cdk-pattern
branch
3 times, most recently
from
9cb2e1b to
94aaeb2
Compare
cemms1
force-pushed
the
use-cdk-pattern
branch
3 times, most recently
from
a3a954c to
ba6c283
Compare
cemms1
force-pushed
the
use-cdk-pattern
branch
2 times, most recently
from
e37649e to
3adde32
Compare
cemms1
force-pushed
the
use-cdk-pattern
branch
2 times, most recently
from
6020e0a to
82a4e58
Compare
Closed
ioannakok
reviewed
Jan 3, 2024
ioannakok
reviewed
Jan 3, 2024
ioannakok
reviewed
Jan 3, 2024
ioannakok
approved these changes
Jan 3, 2024
Contributor
ioannakok
left a comment
ioannakok
left a comment
There was a problem hiding this comment.
Amazing work!! Just added a few questions for my understanding
cemms1
force-pushed
the
use-cdk-pattern
branch
from
66b960b to
59b84d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is an updated version of #9389
What does this change?
Adds a new CDK stack, using the
GuEc2Apppattern. This has the bonus of allowing us to use an ALB rather than an ELB. It also reduces the amount of code the WebX team have to write and maintain for our infrastructure provisioning.As part of adding the new stack, we've adapted our naming strategy and opted for prefixing the words
appandstackwithguorcdkwhere appropriate, since the concept of these things means totally different things in the Guardian or AWS contexts.This work is part of a larger piece of work aiming to split DCR into a number of separate rendering applications to manage the scaling of our application in a better way.
We are considering having the following apps:
article(includes all articles except interactive articles)facia(includes front pages and tag pages)interactives(handles the interactive articles separated from thearticleapp)misc(other DCR-supported pages that aren't articles, front pages, or tag pages e.g. the all newsletters page)This PR:
article-renderingapp (incdk/lib/renderingStack.tsandcdk/bin/cdk.ts)ec2AppGuCDK patternscripts/deploy/riff-raff-v2.yamldotcom:rendering-allas opposed to the existing deployment ofdotcom:rendering, since this matches the frontend naming stylefront-webapp since this was not usedWhy?
Resolves #9374 and will resolve #9310