feat(FR-2664): add /deployments + /admin-deployments routes with legacy fallbacks by agatha197 · Pull Request #6907 · lablup/backend.ai-webui

agatha197 · 2026-04-22T10:20:17Z

Resolves FR-2664 (parent story: FR-2657; epic: FR-1368)

Summary

Phase 1 / Foundation step for migrating the Endpoint UI to the new Deployment UI. This PR wires the new route surface and legacy fallbacks so subsequent phases (FR-2671 list, FR-2675 launcher, FR-2681 detail, FR-2672 admin list) can land against a stable URL contract.

New routes

/deployments -> DeploymentListPage (user view)
/deployments/new -> DeploymentLauncherPage (create)
/deployments/:deploymentId -> DeploymentDetailPage
/deployments/:deploymentId/edit -> DeploymentLauncherPage (edit)
/admin-deployments -> AdminDeploymentListPage

All four pages are stub placeholders rendering TODO: ...PageName — FR-XXXX so the routes are mergeable before the real implementations land. Each stub carries a TODO(needs-backend) marker (well, needs-page) referencing the phase ticket.

Legacy fallbacks (transient redirects)

Old path	New path
`/serving`	`/deployments`
`/serving/:serviceId`	`/deployments/:serviceId`
`/admin-serving`	`/admin-deployments`
`/admin-serving/:serviceId`	`/deployments/:serviceId` (shared detail page)
`/service/:endpointId`	`/deployments/:endpointId`
`/service/:endpointId/edit`	`/deployments/:endpointId/edit`

Query strings are preserved through the redirects via useLocation().search. These fallbacks are documented in the code as transient and scheduled for removal once internal links and external references have migrated.

/service/start and /service/update/:endpointId are intentionally left untouched — those are live launcher paths still in use until the Deployment Launcher (FR-2675) lands.

Misc

Removed now-unused ServingPage, EndpointDetailPage, AdminServingPage imports from routes.tsx. The underlying page files are kept on disk for the Phase 3/4/5 implementations to reference.

Verification

bash scripts/verify.sh
=== Relay ===  PASS
=== Lint ===   PASS
=== Format === PASS
=== TypeScript === PASS
=== ALL PASS ===

Checklist

TypeScript / Relay / Lint / Format all pass
TODO(needs-backend) style markers placed on stub pages with phase ticket refs
Query strings preserved through all legacy-path redirects
No unrelated scope creep (only routes.tsx + 4 new stub pages)

agatha197 · 2026-04-22T10:20:32Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

feat(FR-2665): rename sidebar menu Serving → Deployments #6905
feat(FR-2664): add /deployments + /admin-deployments routes with legacy fallbacks #6907 👈 (View in Graphite)
feat(FR-2666): add Deployment i18n keys (en.json foundation) #6906
feat(FR-1368): add deployment infrastructure — feature flag, i18n keys, routes, and sidebar #6904 : 1 other dependent PR (#6910 )
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-04-22T10:23:36Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	8.59% (-0.01% 🔻)	1758/20465
🔴	Branches	7.89%	1131/14338
🔴	Functions	5.15% (+0.01% 🔼)	286/5557
🔴	Lines	8.31% (-0.01% 🔻)	1650/19860

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🔴	`...` / AdminDeploymentListPage.tsx	0%	100%	0%	0%
🔴	`...` / DeploymentLauncherPage.tsx	0%	100%	0%	0%
🔴	`...` / DeploymentDetailPage.tsx	0%	100%	0%	0%
🔴	`...` / DeploymentListPage.tsx	0%	100%	0%	0%

Test suite run success

856 tests passing in 39 suites.

Report generated by 🧪jest coverage report action from c0a7db6

Copilot

Pull request overview

Introduces new “Deployments” route namespaces (/deployments, /admin-deployments) and adds redirect-based legacy fallbacks from existing Serving-related routes (/serving, /admin-serving, and some /service/* paths) as part of the FR-2664 migration foundation.

Changes:

Add /deployments route tree (list/new/detail/edit) and redirect legacy /serving/* traffic to it.
Add /admin-deployments route and redirect legacy /admin-serving/* traffic to it.
Add placeholder stub pages for the new Deployment routes.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
react/src/routes.tsx	Wires new `/deployments` and `/admin-deployments` routes and adds redirect fallbacks from legacy Serving routes.
react/src/pages/DeploymentListPage.tsx	Adds stub placeholder page for deployments list.
react/src/pages/DeploymentLauncherPage.tsx	Adds stub placeholder page for deployments create/edit.
react/src/pages/DeploymentDetailPage.tsx	Adds stub placeholder page for deployment details.
react/src/pages/AdminDeploymentListPage.tsx	Adds stub placeholder page for admin deployments list.

Copilot · 2026-04-22T10:25:08Z

+    // FR-2664 — New admin deployment list route. Replaces the legacy
+    // /admin-serving route (see fallback redirect below).
+    path: '/admin-deployments',
+    handle: { labelKey: 'webui.menu.Serving' },
+    Component: () => {
+      const { t } = useTranslation();
+      return (
+        <BAIErrorBoundary>
+          <Suspense
+            fallback={<BAICard title={t('webui.menu.Serving')} loading />}
+          >
+            <AdminDeploymentListPage />
+          </Suspense>
+        </BAIErrorBoundary>
+      );
+    },
+  },
+  {
+    // FR-2664 — Legacy /admin-serving fallback. Transient redirect; remove
+    // once all internal links + external references have been migrated.
    path: '/admin-serving',
    handle: { labelKey: 'webui.menu.Serving' },
    children: [
      {
        index: true,
        Component: () => {
-          const { t } = useTranslation();
+          const location = useLocation();
          return (
-            <BAIErrorBoundary>
-              <Suspense
-                fallback={<BAICard title={t('webui.menu.Serving')} loading />}
-              >
-                <AdminServingPage />
-              </Suspense>
-            </BAIErrorBoundary>
+            <WebUINavigate
+              to={'/admin-deployments' + location.search}
+              replace
+            />
          );
        },
      },
      {
+        // /admin-deployments has no nested detail route — the deployment
+        // detail page is shared at /deployments/:deploymentId regardless
+        // of the viewer's role.
        path: ':serviceId',
-        element: (
-          <Suspense fallback={<Skeleton active />}>
-            <EndpointDetailPage />
-          </Suspense>
-        ),
-        handle: { labelKey: 'modelService.RoutingInfo' },
+        Component: () => {
+          const { serviceId } = useParams<{ serviceId: string }>();
+          const location = useLocation();
+          return (
+            <WebUINavigate
+              to={`/deployments/${serviceId}${location.search}`}
+              replace
+            />
+          );
+        },
      },
    ],
  },


/admin-serving is changed into a redirect to /admin-deployments, but /admin-deployments currently renders a stub placeholder. This removes the existing admin Serving page behavior (including the tabbed model-store management UI) and will break current admin workflows. Until the admin deployment list is implemented, consider keeping /admin-serving rendering AdminServingPage (or have /admin-deployments temporarily alias to it) rather than redirecting to an unimplemented page.

Copilot · 2026-04-22T10:25:08Z

+
+// TODO(needs-backend): FR-2671 — Deployment list page (user view).
+// This is a placeholder stub introduced by FR-2664 so that the new
+// /deployments route can be wired before the real page lands in Phase 3.
+const DeploymentListPage: React.FC = () => {
+  'use memo';
+  return <div>TODO: DeploymentListPage — FR-2671</div>;


This placeholder page renders a hard-coded "TODO" string directly to users. In this codebase, user-facing strings are typically localized via useTranslation(); shipping visible TODO content is likely unintended. Consider gating the route behind a feature flag, rendering an existing "not available"/404 view, or at least using a localized placeholder message.

Suggested change

// TODO(needs-backend): FR-2671 — Deployment list page (user view).

// This is a placeholder stub introduced by FR-2664 so that the new

// /deployments route can be wired before the real page lands in Phase 3.

const DeploymentListPage: React.FC = () => {

'use memo';

return <div>TODO: DeploymentListPage — FR-2671</div>;

import { useTranslation } from 'react-i18next';

// TODO(needs-backend): FR-2671 — Deployment list page (user view).

// This is a placeholder stub introduced by FR-2664 so that the new

// /deployments route can be wired before the real page lands in Phase 3.

const DeploymentListPage: React.FC = () => {

'use memo';

const { t } = useTranslation();

return <div>{t('deploymentListPage.placeholder', 'Deployment list is not available yet.')}</div>;

Copilot · 2026-04-22T10:25:08Z

+// TODO(needs-backend): FR-2675 — Deployment launcher page (create + edit).
+// This is a placeholder stub introduced by FR-2664 so that the new
+// /deployments/new and /deployments/:deploymentId/edit routes can be
+// wired before the real page lands in Phase 3.
+const DeploymentLauncherPage: React.FC = () => {
+  'use memo';
+  return <div>TODO: DeploymentLauncherPage — FR-2675</div>;
+};


This placeholder page renders a hard-coded "TODO" string directly to users. In this codebase, user-facing strings are typically localized via useTranslation(); shipping visible TODO content is likely unintended. Consider gating the route behind a feature flag, rendering an existing "not available"/404 view, or at least using a localized placeholder message.

Copilot · 2026-04-22T10:25:09Z

+// TODO(needs-backend): FR-2681 — Deployment detail page.
+// This is a placeholder stub introduced by FR-2664 so that the new
+// /deployments/:deploymentId route can be wired before the real page
+// lands in Phase 4.
+const DeploymentDetailPage: React.FC = () => {
+  'use memo';
+  return <div>TODO: DeploymentDetailPage — FR-2681</div>;
+};


This placeholder page renders a hard-coded "TODO" string directly to users. In this codebase, user-facing strings are typically localized via useTranslation(); shipping visible TODO content is likely unintended. Consider gating the route behind a feature flag, rendering an existing "not available"/404 view, or at least using a localized placeholder message.

Copilot · 2026-04-22T10:25:09Z

+// TODO(needs-backend): FR-2672 — Admin deployment list page.
+// This is a placeholder stub introduced by FR-2664 so that the new
+// /admin-deployments route can be wired before the real page lands in
+// Phase 5.
+const AdminDeploymentListPage: React.FC = () => {
+  'use memo';
+  return <div>TODO: AdminDeploymentListPage — FR-2672</div>;
+};


This placeholder page renders a hard-coded "TODO" string directly to users. In this codebase, user-facing strings are typically localized via useTranslation(); shipping visible TODO content is likely unintended. Consider gating the route behind a feature flag, rendering an existing "not available"/404 view, or at least using a localized placeholder message.

Copilot · 2026-04-22T10:25:09Z

@@ -262,19 +273,79 @@ export const mainLayoutChildRoutes: RouteObject[] = [
            <Suspense
              fallback={<BAICard title={t('webui.menu.Serving')} loading />}
            >
-              <ServingPage />
+              <DeploymentListPage />
            </Suspense>
          );
        },


The new routing makes /serving a redirect to /deployments, but /deployments currently renders stub placeholder pages. This effectively removes the existing Serving UI (ServingPage + EndpointDetailPage) and will regress production functionality for users navigating via the menu or existing deep links. Consider keeping the legacy pages mounted (e.g., have /deployments temporarily render the existing ServingPage and detail page) or keep /serving as the primary route until the Deployment pages are implemented, instead of redirecting users to stubs.

…cy fallbacks

agatha197 · 2026-04-23T02:23:39Z

Consolidated into grouped PR stack (Foundation/Components/Launcher/List/Detail). Closing this individual PR.

Copilot AI review requested due to automatic review settings April 22, 2026 10:20

github-actions Bot assigned agatha197 Apr 22, 2026

github-actions Bot added the size:L 100~500 LoC label Apr 22, 2026

Copilot started reviewing on behalf of agatha197 April 22, 2026 10:20 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

feat(FR-2664): add /deployments + /admin-deployments routes with lega…

c0a7db6

…cy fallbacks

agatha197 changed the base branch from main to graphite-base/6907 April 22, 2026 14:01

agatha197 force-pushed the 04-22-feat_fr-2664_add__deployments__admin-deployments_routes_with_legacy_fallbacks branch from b121d02 to c0a7db6 Compare April 22, 2026 14:02

agatha197 changed the base branch from graphite-base/6907 to 04-22-feat_fr-2666_add_deployment_i18n_keys April 22, 2026 14:02

agatha197 closed this Apr 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(FR-2664): add /deployments + /admin-deployments routes with legacy fallbacks#6907

feat(FR-2664): add /deployments + /admin-deployments routes with legacy fallbacks#6907
agatha197 wants to merge 1 commit into
04-22-feat_fr-2666_add_deployment_i18n_keysfrom
04-22-feat_fr-2664_adddeploymentsadmin-deployments_routes_with_legacy_fallbacks

agatha197 commented Apr 22, 2026 •

edited

Loading

Uh oh!

agatha197 commented Apr 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

agatha197 commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

agatha197 commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

New routes

Legacy fallbacks (transient redirects)

Misc

Verification

Checklist

Uh oh!

agatha197 commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

agatha197 commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

agatha197 commented Apr 22, 2026 •

edited

Loading

agatha197 commented Apr 22, 2026 •

edited

Loading

github-actions Bot commented Apr 22, 2026 •

edited

Loading

Coverage report for `./react`