Skip to content

feat(FR-2666): add Deployment i18n keys (en.json foundation)#6906

Closed
agatha197 wants to merge 1 commit into
graphite-base/6906from
04-22-feat_fr-2666_add_deployment_i18n_keys
Closed

feat(FR-2666): add Deployment i18n keys (en.json foundation)#6906
agatha197 wants to merge 1 commit into
graphite-base/6906from
04-22-feat_fr-2666_add_deployment_i18n_keys

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

resolves #NNN (FR-MMM)

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copilot AI review requested due to automatic review settings April 22, 2026 10:20
@github-actions github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels Apr 22, 2026
Copy link
Copy Markdown
Contributor Author

agatha197 commented Apr 22, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds English i18n strings needed for the Deployments UI, establishing initial deployment.* and replicaStatus.* namespaces and wiring new menu labels.

Changes:

  • Add a new deployment namespace with labels/messages for deployment creation, configuration, status, and navigation.
  • Add a new top-level replicaStatus namespace with status labels and tooltip texts.
  • Add webui.menu entries for “Deployments” and “Admin Deployments”.

Comment thread resources/i18n/en.json
Comment on lines +755 to +760
"deployment": {
"AccessToken": "Access Token",
"AccessTokens": "Access Tokens",
"ActivePool": "Active Pool",
"ActivePoolDescription": "Replicas currently receiving traffic through AppProxy.",
"ActivenessStatus": "Activeness Status",
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New i18n keys are added only to en.json. None of the other locale files under resources/i18n/ contain the new "deployment" / "replicaStatus" namespaces, so non-English locales will be missing these keys at runtime. Please run the repo’s i18n scanner (make i18n / i18next-scanner) and commit the updated locale JSONs (at least adding NOT_TRANSLATED placeholders for other languages).

Copilot uses AI. Check for mistakes.
Comment thread resources/i18n/en.json
Comment on lines 3114 to +3116
"AboutBackendAI": "About Backend.AI",
"AdminDashboard": "Admin Dashboard",
"AdminDeployments": "Admin Deployments",
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description still contains unresolved placeholders (e.g., “resolves #NNN (FR-MMM)” and checklist/template items). Please update the PR description with the actual issue/Jira references and concrete review/testing notes so the change can be traced and reviewed properly.

Copilot uses AI. Check for mistakes.
@agatha197 agatha197 changed the base branch from main to graphite-base/6906 April 22, 2026 14:01
@agatha197 agatha197 force-pushed the 04-22-feat_fr-2666_add_deployment_i18n_keys branch from f3e0367 to 5b18423 Compare April 22, 2026 14:02
@agatha197 agatha197 changed the base branch from graphite-base/6906 to 04-22-feat_fr-2663_add_model-deployment-extended-filter_feature_flag April 22, 2026 14:02
@agatha197 agatha197 changed the base branch from 04-22-feat_fr-2663_add_model-deployment-extended-filter_feature_flag to graphite-base/6906 April 23, 2026 02:21
@agatha197
Copy link
Copy Markdown
Contributor Author

Consolidated into grouped PR stack (Foundation/Components/Launcher/List/Detail). Closing this individual PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants