fix(FR-2774): query runtime variant id and decode to UUID for addModelRevision by nowgnuesLee · Pull Request #7152 · lablup/backend.ai-webui

nowgnuesLee · 2026-04-29T09:32:16Z

Summary

addModelRevision failed end-to-end after createModelDeployment succeeded, leaving the new deployment without a revision. Two related fixes that match the working pattern in DeploymentAddRevisionModal.tsx and DeploymentRevisionHistoryTab.tsx.

1. Runtime variant id resolution

DeploymentLauncherPageRuntimeVariantsQuery now selects id (Strawberry global) instead of rowId. In some live-server responses rowId returned null, tripping the frontend Unknown runtime variant guard at DeploymentLauncherPage.tsx:314.
handleAddRevision decodes the global id via toLocalId to derive the local UUID expected by ModelRuntimeConfigInput.runtimeVariantId: UUID!. Falls back to the raw id if toLocalId returns null, mirroring DeploymentAddRevisionModal.tsx:204 (toLocalId(node.id) ?? node.id).
DeploymentLauncherPageContent.runtimeVariants prop type updated from { name; rowId } to { name; id }.

2. `deploymentId` / `id` fields → UUID, not Strawberry global ID

AddRevisionInput.deploymentId and UpdateDeploymentInput.id are typed as ID! in data/schema.graphql, but the server resolvers expect the local UUID, not the Relay global ID. Working patterns in the same project:

DeploymentAddRevisionModal.tsx:378: deploymentId: toLocalId(deploymentId) ?? deploymentId
DeploymentRevisionHistoryTab.tsx: id: toLocalId(deployment.id), activeRevisionId: toLocalId(revision.id)

Previously the launcher wrapped both with toGlobalId('ModelDeployment', ...) before submitting, so the server rejected with badly formed hexadecimal UUID string after createModelDeployment succeeded. Now both commitEdit (addModelRevision) and commitUpdateReplica (updateModelDeployment) send the local UUID directly. The deployment(id: $deploymentId) query keeps toGlobalId(...) since Relay Node queries do require the global ID format.

The schema/runtime divergence (ID! typed but UUID expected) is a server-side documentation gap; flagging here so the next person doesn't reintroduce the wrap.

Test plan

bash scripts/verify.sh passes (Relay / Lint / Format / TypeScript).
/deployments/create: filling the launcher and clicking Create Deployment completes without errors; the new deployment lands on /deployments/:id with the initial revision active. (User-verified in dev.)
/deployments/:id/edit: saving runs addModelRevision + updateModelDeployment in parallel and both succeed; new revision appears in history; replica count updates.

nowgnuesLee · 2026-04-29T09:32:41Z

fix(FR-2780): apply deployment launcher post-migration feedback #7167
fix(FR-2776): adapt addModelRevision call sites to new schema #7158
fix(FR-2773): preserve auto-selected resourcePresetId across applyInitialValues #7153
fix(FR-2774): query runtime variant id and decode to UUID for addModelRevision #7152 👈 (View in Graphite)
refactor(FR-2772): unify deployment card UX with BAICard conventions #7146
fix(FR-2767): apply deployment migration feedback #7141
feat(FR-2767): redirect to launcher when no deployment presets available #7136
feat(FR-2664): apply meeting feedback — split config card, add endpoint URL, imageV2, reorder tabs #7102
fix(FR-2709): resolve notification render loop and sider init error #6985
feat(FR-1368): add deployment detail — configuration section, 4 tabs, and DeploymentDetailPage #6917 : 2 other dependent PRs (#6920 , #7038 )
feat(FR-1368): add deployment list — table, DeploymentListPage, and AdminDeploymentListPage #6916
feat(FR-1368): add deployment launcher — multi-step form, hook, page, and deploy split buttons #6912 : 2 other dependent PRs (#6911 , #6940 )
feat(FR-1368): add shared deployment UI components — ReplicaStatusTag, DeploymentStatusTag, DeploymentOwnerInfo #6910 : 1 other dependent PR (#6908 )
feat(FR-1368): add deployment infrastructure — feature flag, i18n keys, routes, and sidebar #6904 : 1 other dependent PR (#6906 )
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-04-29T09:35:41Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	8.12% (+0% 🔼)	1859/22902
🔴	Branches	7.35% (-0% 🔻)	1187/16156
🔴	Functions	4.83% (+0.02% 🔼)	297/6153
🔴	Lines	7.89% (+0% 🔼)	1750/22188

Test suite run success

865 tests passing in 40 suites.

Report generated by 🧪jest coverage report action from d033937

Copilot

Pull request overview

Updates the deployment launcher flow to use the runtime variant’s GraphQL id (global ID) from the runtimeVariants query and decode it into the UUID required by the addModelRevision mutation.

Changes:

Switched runtimeVariants query selection from rowId to id.
Decoded the runtime variant global ID to a local UUID when resolving runtimeVariantId for addModelRevision.
Updated DeploymentLauncherPageContent prop typing to reflect { name, id }.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
react/src/pages/DeploymentLauncherPage.tsx	Queries `runtimeVariants.node.id` and decodes it to a UUID for `modelRuntimeConfig.runtimeVariantId` during submit.
react/src/components/DeploymentLauncherPageContent.tsx	Updates the `runtimeVariants` prop type from `{ name, rowId }` to `{ name, id }`.

graphite-app · 2026-04-30T06:58:33Z

Merge activity

Apr 30, 6:58 AM UTC: ironAiken2 added this pull request to the Graphite merge queue.
Apr 30, 7:19 AM UTC: Merged by the Graphite merge queue.

…lRevision (#7152) Resolves #7151 ([FR-2774](https://lablup.atlassian.net/browse/FR-2774)) ## Summary `addModelRevision` failed end-to-end after `createModelDeployment` succeeded, leaving the new deployment without a revision. Two related fixes that match the working pattern in `DeploymentAddRevisionModal.tsx` and `DeploymentRevisionHistoryTab.tsx`. ### 1. Runtime variant id resolution - `DeploymentLauncherPageRuntimeVariantsQuery` now selects `id` (Strawberry global) instead of `rowId`. In some live-server responses `rowId` returned null, tripping the frontend `Unknown runtime variant` guard at `DeploymentLauncherPage.tsx:314`. - `handleAddRevision` decodes the global id via `toLocalId` to derive the local UUID expected by `ModelRuntimeConfigInput.runtimeVariantId: UUID!`. Falls back to the raw `id` if `toLocalId` returns null, mirroring `DeploymentAddRevisionModal.tsx:204` (`toLocalId(node.id) ?? node.id`). - `DeploymentLauncherPageContent.runtimeVariants` prop type updated from `{ name; rowId }` to `{ name; id }`. ### 2. `deploymentId` / `id` fields → UUID, not Strawberry global ID `AddRevisionInput.deploymentId` and `UpdateDeploymentInput.id` are typed as `ID!` in `data/schema.graphql`, but the server resolvers expect the **local UUID**, not the Relay global ID. Working patterns in the same project: - `DeploymentAddRevisionModal.tsx:378`: `deploymentId: toLocalId(deploymentId) ?? deploymentId` - `DeploymentRevisionHistoryTab.tsx`: `id: toLocalId(deployment.id)`, `activeRevisionId: toLocalId(revision.id)` Previously the launcher wrapped both with `toGlobalId('ModelDeployment', ...)` before submitting, so the server rejected with `badly formed hexadecimal UUID string` after `createModelDeployment` succeeded. Now both `commitEdit` (`addModelRevision`) and `commitUpdateReplica` (`updateModelDeployment`) send the local UUID directly. The `deployment(id: $deploymentId)` query keeps `toGlobalId(...)` since Relay Node queries do require the global ID format. > The schema/runtime divergence (`ID!` typed but UUID expected) is a server-side documentation gap; flagging here so the next person doesn't reintroduce the wrap. ## Test plan - [x] `bash scripts/verify.sh` passes (Relay / Lint / Format / TypeScript). - [x] `/deployments/create`: filling the launcher and clicking **Create Deployment** completes without errors; the new deployment lands on `/deployments/:id` with the initial revision active. (User-verified in dev.) - [ ] `/deployments/:id/edit`: saving runs `addModelRevision` + `updateModelDeployment` in parallel and both succeed; new revision appears in history; replica count updates. [FR-2774]: https://lablup.atlassian.net/browse/FR-2774?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

…tialValues (#7153) Resolves #7150 ([FR-2773](https://lablup.atlassian.net/browse/FR-2773)) > Stacks on top of #7152 (FR-2774). ## Summary The Resource Preset row showed `-` on the deployment launcher review step even though the user had a preset selected on step 3. Fixed by extending the `applyInitialValues` omit list so any field whose child component owns an `autoSelectDefault` flow is left alone when its merged value is empty. ## Root cause 1. On mount, `ResourcePresetSelect`'s `autoSelectDefault` effect (a child) runs **before** the parent's `applyInitialValues` effect. 2. Auto-select sets `resourcePresetId` to the first available preset name. 3. `applyInitialValues` then runs and called `form.setFieldsValue(merged)` with `merged.resourcePresetId === undefined`, clobbering the auto-selected value. 4. `ResourcePresetSelect` uses `useControllableState_deprecated`, whose `stateRef` retains the auto-selected value when the antd-injected `value` is `undefined`. So the step-3 Select **kept displaying** the preset name (giving the user the impression it was selected), while `form.getFieldsValue()` returned `undefined`. 5. The review summary's `values.resourcePresetId ? <ResourcePresetReviewDisplay … /> : '-'` fell to the dash branch. The existing code already handled the same race for `resourceGroup` via `_.omit(merged, 'resourceGroup')`. This PR generalizes that omit list to also cover `resourcePresetId`. ## Test plan - [ ] `bash scripts/verify.sh` passes. - [ ] `/deployments/create`: select a resource group, allow auto-select to pick a preset on step 3, click Next → review step renders the preset name and resource slot icons (no `-`). - [ ] Manually change the resource preset on step 3 → review reflects the new preset. - [ ] Edit mode (`/deployments/:id/edit`): pre-filled preset still renders on review. - [ ] Edge: open `/deployments/create` directly (no URL pre-fill) and skip to review immediately → preset row shows the auto-selected preset, not `-`. [FR-2773]: https://lablup.atlassian.net/browse/FR-2773?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Resolves #7157 ([FR-2776](https://lablup.atlassian.net/browse/FR-2776)) > Stacks on top of #7153 (FR-2773) → #7152 (FR-2774). ## Symptom Relay compile errors after a schema sync: ``` ✖︎ Unknown argument 'options'. react/src/components/DeploymentAddRevisionModal.tsx:172:41 react/src/pages/DeploymentLauncherPage.tsx:259:41 ``` ## Schema change `addModelRevision` no longer takes `options` as a top-level mutation argument. The `AddRevisionOptions` payload is now a field on `AddRevisionInput`: ```graphql # Before addModelRevision(input: AddRevisionInput!, options: AddRevisionOptions): AddRevisionPayload! # After addModelRevision(input: AddRevisionInput!): AddRevisionPayload! # AddRevisionInput now has: options: AddRevisionOptions = null ``` ## Changes ### `react/src/pages/DeploymentLauncherPage.tsx` - `DeploymentLauncherPageEditMutation`: drop the `$options: AddRevisionOptions` variable and the `, options: $options` argument from the `addModelRevision` selection. - `handleAddRevision`: move `options: { autoActivate: true }` from `variables` (top level) into `variables.input`. ### `react/src/components/DeploymentAddRevisionModal.tsx` - `DeploymentAddRevisionModalAddMutation`: drop the inline `options: { autoActivate: true }` argument from the `addModelRevision` selection. - `commitAdd`: pass `options: { autoActivate: true }` inside the `input` payload. ### `data/schema.graphql` - Sync to the new server schema (drives Relay compiler against the latest definition). ## Test plan - [x] `pnpm run relay` compiles without errors. - [x] `bash scripts/verify.sh` passes (Relay / Lint / Format / TypeScript). - [ ] `/deployments/create`: create-then-add-revision flow still produces an active revision (auto-activated). - [ ] Standalone Add Revision modal: clicking "Add Revision" creates a new revision and auto-activates it. [FR-2776]: https://lablup.atlassian.net/browse/FR-2776?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Copilot AI review requested due to automatic review settings April 29, 2026 09:32

github-actions Bot assigned nowgnuesLee Apr 29, 2026

github-actions Bot added the size:S 10~30 LoC label Apr 29, 2026

agatha197 mentioned this pull request Apr 29, 2026

fix(FR-2767): apply deployment migration feedback #7141

Merged

This was referenced Apr 29, 2026

refactor(FR-2772): unify deployment card UX with BAICard conventions #7146

Merged

fix(FR-2773): preserve auto-selected resourcePresetId across applyInitialValues #7153

Merged

Copilot started reviewing on behalf of nowgnuesLee April 29, 2026 09:32 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread react/src/pages/DeploymentLauncherPage.tsx Outdated

nowgnuesLee force-pushed the 04-29-fix_fr-2774_query_runtime_variant_id_and_decode_to_uuid_for_addmodelrevision branch 2 times, most recently from 864d385 to 196024c Compare April 29, 2026 10:48

github-actions Bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Apr 29, 2026

nowgnuesLee force-pushed the 04-29-fix_fr-2774_query_runtime_variant_id_and_decode_to_uuid_for_addmodelrevision branch from 196024c to f5f8814 Compare April 30, 2026 01:37

This was referenced Apr 30, 2026

Adapt addModelRevision call sites to new schema (options moved into AddRevisionInput) #7156

Closed

fix(FR-2776): adapt addModelRevision call sites to new schema #7158

Merged

ironAiken2 force-pushed the 04-29-fix_fr-2774_query_runtime_variant_id_and_decode_to_uuid_for_addmodelrevision branch from f5f8814 to b6d3266 Compare April 30, 2026 06:51

ironAiken2 force-pushed the 04-29-refactor_fr-2772_unify_deployment_card_ux_with_baicard_conventions branch from aafe474 to 2f19399 Compare April 30, 2026 06:51

ironAiken2 mentioned this pull request Apr 30, 2026

fix(FR-2780): apply deployment launcher post-migration feedback #7167

Merged

12 tasks

graphite-app Bot force-pushed the 04-29-refactor_fr-2772_unify_deployment_card_ux_with_baicard_conventions branch from 2f19399 to ca553e6 Compare April 30, 2026 07:04

graphite-app Bot force-pushed the 04-29-fix_fr-2774_query_runtime_variant_id_and_decode_to_uuid_for_addmodelrevision branch from b6d3266 to d033937 Compare April 30, 2026 07:05

Base automatically changed from 04-29-refactor_fr-2772_unify_deployment_card_ux_with_baicard_conventions to main April 30, 2026 07:18

graphite-app Bot merged commit d033937 into main Apr 30, 2026
8 checks passed

graphite-app Bot deleted the 04-29-fix_fr-2774_query_runtime_variant_id_and_decode_to_uuid_for_addmodelrevision branch April 30, 2026 07:19

github-pages Bot temporarily deployed to github-pages April 30, 2026 07:20 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(FR-2774): query runtime variant id and decode to UUID for addModelRevision#7152

fix(FR-2774): query runtime variant id and decode to UUID for addModelRevision#7152
graphite-app[bot] merged 1 commit into
mainfrom
04-29-fix_fr-2774_query_runtime_variant_id_and_decode_to_uuid_for_addmodelrevision

nowgnuesLee commented Apr 29, 2026 •

edited by atlassian Bot

Loading

Uh oh!

nowgnuesLee commented Apr 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nowgnuesLee commented Apr 29, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

1. Runtime variant id resolution

2. deploymentId / id fields → UUID, not Strawberry global ID

Test plan

Uh oh!

nowgnuesLee commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

graphite-app Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nowgnuesLee commented Apr 29, 2026 •

edited by atlassian Bot

Loading

2. `deploymentId` / `id` fields → UUID, not Strawberry global ID

nowgnuesLee commented Apr 29, 2026 •

edited

Loading

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Coverage report for `./react`

graphite-app Bot commented Apr 30, 2026 •

edited

Loading