Skip to content

fix(FR-2767): apply deployment migration feedback#7141

Merged
graphite-app[bot] merged 1 commit into
mainfrom
fix/FR-2769-apply-deployment-migration-feedback
Apr 30, 2026
Merged

fix(FR-2767): apply deployment migration feedback#7141
graphite-app[bot] merged 1 commit into
mainfrom
fix/FR-2769-apply-deployment-migration-feedback

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Apr 28, 2026 •
edited by atlassian Bot
Loading

Resolves #7140 (FR-2769)

Summary

Applies all deployment migration review feedback:

  • VFolderSelect: Remove ownership_type !== 'group' filter so group-owned model folders display by name instead of raw UUID
  • Tags Select: Add open=false to prevent auto-opening on step render
  • ResourcePresetSelect: Fix auto-select not firing after resource group changes
  • DeploymentRevisionDetailDrawer: Wrap in BAIUnmountAfterClose to clear stale state on close
  • Edit mode: Show modal.error when a deployment update is already in progress
  • AnotherDeploymentInProgress error: Surface translated user-friendly message instead of raw server error
  • Access token delete: Implement delete action using deleteAccessToken mutation with confirmation
  • CreateAccessTokenModal: Replace free-form date input with Select (7/30/90 days, custom, no expiration)
  • DeploymentList: Remove custom empty text to align with admin-session table style
  • desiredReplicaCount: Add required+min:1 validation; wire to server in both create and edit modes; run addModelRevision + updateModelDeployment in parallel during edit

Known Issue (Pending Investigation)

⚠️ VFolderSelect still shows raw ID in one flow: When opening the launcher via "세부 설정 후 배포하기" in VFolderDeployModal, the VFolderSelect still renders the folder ID instead of the folder name. The ownership filter fix above resolves the case where the folder is pre-filled from the URL/model param, but the modal flow passes the folder ID via openLauncher({ modelFolderId }) and the Select cannot find a matching option in time. Further investigation needed.

This was referenced Apr 28, 2026
Merged
Merged
@agatha197 agatha197 mentioned this pull request Apr 28, 2026
Merged
@agatha197 Graphite App
Copy link
Copy Markdown
Contributor Author

agatha197 commented Apr 28, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 marked this pull request as ready for review April 28, 2026 13:06
@github-actions github-actions Bot added the size:L 100~500 LoC label Apr 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026 •
edited
Loading

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
8.14% (-0% 🔻)
 1859/22830
🔴 Branches
7.36% (-0.01% 🔻)
 1187/16126
🔴 Functions
4.84% (+0.01% 🔼)
 297/6138
🔴 Lines
7.91% (-0% 🔻)
 1750/22117

Test suite run success

865 tests passing in 40 suites.

Report generated by 🧪jest coverage report action from 5de1b0e

@ironAiken2 ironAiken2 force-pushed the feat/FR-2767-redirect-to-launcher-when-no-presets branch from d3e9533 to 83a8148 Compare April 29, 2026 08:28
@ironAiken2 ironAiken2 force-pushed the fix/FR-2769-apply-deployment-migration-feedback branch from 3043499 to 1a6e009 Compare April 29, 2026 08:28
@github-actions github-actions Bot added area:ux UI / UX issue. area:i18n Localization labels Apr 29, 2026
@ironAiken2 ironAiken2 mentioned this pull request Apr 29, 2026
Merged
8 tasks
This was referenced Apr 29, 2026
Merged
Merged
Merged
@ironAiken2 ironAiken2 force-pushed the fix/FR-2769-apply-deployment-migration-feedback branch from 1a6e009 to a254fa5 Compare April 30, 2026 06:51
@ironAiken2 ironAiken2 force-pushed the feat/FR-2767-redirect-to-launcher-when-no-presets branch from 83a8148 to 19fc770 Compare April 30, 2026 06:51
@ironAiken2 ironAiken2 mentioned this pull request Apr 30, 2026
Merged
12 tasks
ironAiken2
ironAiken2 approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 30, 2026 •
edited
Loading

Merge activity

@agatha197
fix(FR-2767): apply deployment migration feedback (#7141)
5de1b0e 
Resolves #7140 ([FR-2769](https://lablup.atlassian.net/browse/FR-2769))

## Summary

Applies all deployment migration review feedback:

- **VFolderSelect**: Remove `ownership_type !== 'group'` filter so group-owned model folders display by name instead of raw UUID
- **Tags Select**: Add `open=false` to prevent auto-opening on step render
- **ResourcePresetSelect**: Fix auto-select not firing after resource group changes
- **DeploymentRevisionDetailDrawer**: Wrap in `BAIUnmountAfterClose` to clear stale state on close
- **Edit mode**: Show `modal.error` when a deployment update is already in progress
- **AnotherDeploymentInProgress error**: Surface translated user-friendly message instead of raw server error
- **Access token delete**: Implement delete action using `deleteAccessToken` mutation with confirmation
- **CreateAccessTokenModal**: Replace free-form date input with Select (7/30/90 days, custom, no expiration)
- **DeploymentList**: Remove custom empty text to align with admin-session table style
- **desiredReplicaCount**: Add required+min:1 validation; wire to server in both create and edit modes; run `addModelRevision` + `updateModelDeployment` in parallel during edit

## Known Issue (Pending Investigation)

> ⚠️ **VFolderSelect still shows raw ID in one flow**: When opening the launcher via "세부 설정 후 배포하기" in `VFolderDeployModal`, the VFolderSelect still renders the folder ID instead of the folder name. The ownership filter fix above resolves the case where the folder is pre-filled from the URL/model param, but the modal flow passes the folder ID via `openLauncher({ modelFolderId })` and the Select cannot find a matching option in time. Further investigation needed.

[FR-2769]: https://lablup.atlassian.net/browse/FR-2769?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@graphite-app graphite-app Bot force-pushed the feat/FR-2767-redirect-to-launcher-when-no-presets branch from 19fc770 to bcfb7a5 Compare April 30, 2026 07:03
@graphite-app graphite-app Bot force-pushed the fix/FR-2769-apply-deployment-migration-feedback branch from a254fa5 to 5de1b0e Compare April 30, 2026 07:04
Base automatically changed from feat/FR-2767-redirect-to-launcher-when-no-presets to main April 30, 2026 07:16
@graphite-app graphite-app Bot merged commit 5de1b0e into main Apr 30, 2026
8 checks passed
@graphite-app graphite-app Bot deleted the fix/FR-2769-apply-deployment-migration-feedback branch April 30, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ironAiken2 ironAiken2 ironAiken2 approved these changes

Assignees

@agatha197 agatha197

Labels

area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apply deployment migration feedback

2 participants

@agatha197 @ironAiken2