Skip to content

feat(FR-2674): fix step-4 review completeness and runtime param UX#6940

Closed
agatha197 wants to merge 1 commit into
graphite-base/6940from
04-23-feat_fr-2674_fix_step-4_review_completeness_and_runtime_param_ux
Closed

feat(FR-2674): fix step-4 review completeness and runtime param UX#6940
agatha197 wants to merge 1 commit into
graphite-base/6940from
04-23-feat_fr-2674_fix_step-4_review_completeness_and_runtime_param_ux

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

resolves #NNN (FR-MMM)

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

- Show touched runtime parameters in Model & Runtime review card (snapshot via useEffectEvent)
- Show environment/image selection in review (was missing)
- Resource preset review: remove () wrapper, enable icon tooltips, match session launcher colors
- Fix RuntimeParameterFormSection text_input: show default value as placeholder when untouched so focus does not pre-fill the field
- Fix VFolderLazyView: use useFolderExplorerOpener so clicking folder name in review opens the file browser correctly
Copy link
Copy Markdown
Contributor Author

agatha197 commented Apr 23, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 changed the base branch from 04-22-feat_fr-2674_add_deploymentlauncherpagecontent_multi-step_form to graphite-base/6940 April 23, 2026 06:50
@agatha197
Copy link
Copy Markdown
Contributor Author

Folded into #6912 via gt fold.

@agatha197 agatha197 closed this Apr 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 8.45% 1757/20803
🔴 Branches 7.74% 1131/14620
🔴 Functions 5.05% 285/5644
🔴 Lines 8.17% 1649/20185

Test suite run success

856 tests passing in 39 suites.

Report generated by 🧪jest coverage report action from c4ed328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant