feat(FR-2684): migrate Deploy buttons to [Deploy | ▼] split using useDeploymentLauncher#6928
Conversation
github-actions
Bot
added
area:ux
Contributor
Author
5 tasks
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.27% (-0.01% 🔻) |
1757/21240 |
| 🔴 | Branches | 7.6% (-0.02% 🔻) |
1131/14877 |
| 🔴 | Functions | 4.97% (-0% 🔻) |
285/5735 |
| 🔴 | Lines | 8% (-0% 🔻) |
1649/20603 |
Test suite run success
856 tests passing in 39 suites.
Report generated by 🧪jest coverage report action from 257797e
…DeploymentLauncher
agatha197
changed the base branch from
04-22-feat_fr-2683_add_usedeploymentlauncher_hook_for_quick_deploy
to
graphite-base/6928
agatha197
force-pushed
the
04-22-feat_fr-2684_migrate_deploy_buttons_to_deploy_split_using_usedeploymentlauncher
branch
from
d69ad66 to
6509cb5
Compare
This was referenced Apr 22, 2026
feat(FR-1368): add deployment launcher — multi-step form, hook, page, and deploy split buttons
#6912
Closed
Merged
feat(FR-1368): add deployment detail — configuration section, 4 tabs, and DeploymentDetailPage
#6917
Merged
Closed
Extends the FR-2684 launcher migration to VFolderDeployModal. When supportsQuickDeploy (manager 26.4.3+), the Deploy button becomes a Space.Compact split button: primary fires deployVfolderV2 with the selected preset/resource group, and the ▼ dropdown item calls openLauncher({ modelFolderId }) to navigate to /deployments/new?model=<id> for full configuration. Older managers fall back to the single Deploy button.
agatha197
changed the base branch from
graphite-base/6928
to
04-22-feat_fr-2681_add_deploymentdetailpage_with_header_configuration_overview_and_4_tabs
…lCardDrawer and VFolderDeployModal
…o review step When the user clicks the '...' dropdown item in VFolderDeployModal, openLauncher now forwards resourceGroup and resourcePresetId as URL params alongside the existing model param, and sets step=review so the launcher opens directly on the review page with all fields pre-filled. DeploymentLauncherCreateView parses the new params; preFilledModel prop is replaced by preFilledValues (Partial<DeploymentLauncherFormValue>) to accommodate the expanded field set cleanly.
Two root causes fixed: 1. ReviewSummary had 'use memo' — the React Compiler memoized it on the stable `form` reference, so shouldUpdate re-renders were bailed out even after form.setFieldsValue() set the pre-fill values. Removed 'use memo' so shouldUpdate correctly re-renders the summary. 2. Pre-fill params (resourceGroup, resourcePresetId) were read in DeploymentLauncherCreateView via searchParams and passed as props, which was fragile across Suspense boundaries. Now DeploymentLauncherPageContent reads all pre-fill params directly via nuqs useQueryStates so nuqs tracks and preserves them across step navigation URL updates. preFilledValues prop removed; prop drilling eliminated.
Contributor
Author
|
Consolidated into grouped PR stack (Foundation/Components/Launcher/List/Detail). Closing this individual PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #NNN (FR-MMM)
Checklist: (if applicable)