feat: Implements VerifyBlob functionality#394
Merged
priteshbandi merged 55 commits intonotaryproject:mainfrom Jun 27, 2024
Merged
feat: Implements VerifyBlob functionality#394priteshbandi merged 55 commits intonotaryproject:mainfrom
priteshbandi merged 55 commits intonotaryproject:mainfrom
Conversation
priteshbandi
requested review from
JeyJeyGao,
NiazFK,
SteveLasker,
gokarnm,
justincormack,
rgnote,
shizhMSFT and
toddysm
as code owners
…quest (notaryproject#390) Add contract version to plugin sign request and plugin verify request. As per [specification](https://github.com/notaryproject/specifications/blob/main/specs/plugin-extensibility.md) `contractVersion` is a mandatory field. Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
bumping up oras-go to v2.5.0 along with golang version to v1.21. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 73.43% 80.29% +6.86%
==========================================
Files 24 33 +9
Lines 2507 2340 -167
==========================================
+ Hits 1841 1879 +38
+ Misses 526 324 -202
+ Partials 140 137 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
ghost
reviewed
Apr 3, 2024
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
JeyJeyGao
reviewed
Jun 25, 2024
ghost
reviewed
Jun 26, 2024
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Overall LGTM, with a few suggestions left.
ghost
reviewed
Jun 26, 2024
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
JeyJeyGao
reviewed
Jun 27, 2024
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements VerifyBlob functionality as per https://github.com/notaryproject/specifications/blob/main/specs/trust-store-trust-policy.md
This PRis ready for review