Repository navigation
fix(control-plane): restore Reflect Markdown typography - #4777
Conversation
|
A follow-up on related work: I should have checked for duplicate issues and PRs before opening this draft. A search across open and closed issues/PRs for typography, Markdown rendering, prose, Tailwind, spacing, and fonts found no direct duplicate of the missing typography-plugin registration fix, though search is not conclusive. The relevant earlier work is:
This PR retains those fonts, enables the existing typography plugin under Tailwind v4, and replaces the manual table rules with the plugin's styling. The deliberate preservation in #3149 is useful review context: replacing those rules deserves checks across the shared Markdown consumers, including light/dark tables and the compact renderer. The existing browser checks cover Reflect and the rendered compact component; they do not constitute a browser walkthrough of every shared consumer. I'll continue reviewing this as a focused follow-up to that work. The before/after examples use entirely fictional content. AI assistance: Codex helped research and draft this comment; I personally reviewed the findings and recommendations. |
8a44220 to
d3c1438
Compare
… comment - remove .github/figures/reflect-typography (screenshots belong in the PR description only) - typography.test.ts: name overflow-wrap: anywhere explicitly in the comment
Reflect answers currently lose paragraph spacing, heading hierarchy, and list markers. The UI uses
proseclasses, but Tailwind v4 does not automatically load the typography plugin registered in the legacy JavaScript config. Long answers consequently read as a dense block of text.This registers the existing typography dependency in CSS, following Tailwind's v4 instructions. Reflect answers use 16px body text with 28px line spacing, clear heading sizes, and text blocks capped at 70ch. Tables and code can use the card width; wide tables scroll within the answer without compressing words into narrow columns. Table scroll positions survive edits to the Reflect controls. The existing Inter and JetBrains Mono fonts remain.
The plugin replaces the manual Markdown table overrides and restores styling for other existing
proseconsumers, including directives and Reflect observation details.CompactMarkdownopts out withnot-proseto preserve its own compact styles.Before and after
The same invented astronomy-club response is shown in both captures. All names and content are fictional. API responses were intercepted locally; the screenshots contain no user or bank data. Fixture and capture notes.
Validation
The current branch is rebased onto main at
a921929a0. Local tests, lint, and build checks coverd3c1438743624314043f457a2af877c83d087c7f; Git range-diff confirms both PR patches are unchanged by the rebase.TZ=UTC, two workers).ThinkViewtest preserves table identity after a query edit, and a compiled-CSS check guards the wrapping rule.CompactMarkdown; that remains outside this fix.The earlier Meta Muse CI setup failure occurred before tests: the newer workflow referenced an integration directory absent from the old PR head. Rebasing brings that upstream integration into the checkout without changing the typography patch.
AI assistance
Codex investigated the CSS pipeline, implemented the changes and regression tests, generated the fictional response, ran the checks, and drafted this description. Impeccable supplied typography guidance. An independent review using Codex, Claude Code, CodeRabbit, and SonarQube found the table compression and renderer-identity regressions; Codex reproduced and fixed both. The external evie-kit humanizer checked the PR prose. Evie-kit is the contributor's development toolkit for agent workflows and writing checks; no evie-kit configuration was installed in Hindsight.
This is separate from retain-context PR #4751.