Repository navigation
fix(python-client): restore memory listing filter parity - #5140
Merged
nicoloboschi merged 1 commit intoOct 6, 2026
Merged
nicoloboschi merged 1 commit into
nicoloboschi merged 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
nicoloboschi
force-pushed
the
fix/python-memory-filter-parity-20261002
branch
from
October 6, 2026 08:55
4ed5211 to
94c5cec
Compare
This was referenced Oct 8, 2026
Merged
This was referenced Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The API, generated Python client and TypeScript convenience wrapper already support document_id, state and consolidation_state, but Hindsight.list_memories/alist_memories reject them with TypeError. Python convenience users cannot inspect one document, invalidated facts or failed/pending consolidation without dropping down to the generated API.
Change
Expose and forward all three existing filters in both synchronous and asynchronous wrappers. Append arguments to preserve existing positional calls, document semantics and keep omitted fields absent. Add actual HTTP query serialization for all six state/consolidation combinations and reserved characters in document IDs, an omitted-filter control and a sync/async family guard.
TypeScript listMemories already forwards documentId/state/consolidationState. This restores the existing wrapper contract and does not introduce an endpoint or server behavior.
Verification
Required
scripts/hooks/lint.shwas attempted; frozen dependency synchronization fails because the sparse checkout lacks workspace memberhindsight-all, before lint jobs start. Full server, database and LLM integration suites were not run. These tests exercise the actual imported SDK and generated transport against local aiohttp HTTP routes. GitHub CI is separate from these local checks.Prepared with AI assistance.