Repository navigation
fix(api): don't warn with a traceback when alias resolution hits a missing API key - #5409
Merged
Merged
Conversation
This was referenced Oct 8, 2026
Merged
This was referenced Oct 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bank alias resolution runs before the request is authenticated. With a tenant extension that requires an API key, every request that arrives without one makes the resolver raise
AuthenticationError. That case was caught by the generic handler and logged as aWARNINGwith a full traceback.It is harmless — the id is used as-is and auth rejects the request a moment later — but under steady unauthenticated traffic it logs one traceback per request, which buries the logs you actually need.
Fix
In both places that resolve aliases (
UnknownParamsRouteandMCPMiddleware), catchAuthenticationErroron its own and log it atDEBUGwith no traceback. Any other failure still logs theWARNINGwith traceback, as before.Test plan
tests/test_unknown_params.py: a resolver that raisesAuthenticationErrorlogs oneDEBUGline with no traceback, and a resolver that raises some other error still logs theWARNING. The test fails without the fix.tests/test_unknown_params.pyandtests/test_mcp_routing.pypass (35 tests).ruff check/ruff format --checkare clean.