Repository navigation
fix(control-plane): fix the next build type error in the entity-labels editor - #5518
Merged
Merged
Conversation
#5450 typed onValueChange's argument as MapField["type"], but Select passes a string, so next build fails type checking and every Docker build is red.
This was referenced Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's Docker build fails type checking since #5450:
onValueChangewas typed as(v: MapField["type"]) => void, but the Select passes a plain string. This takes the string and casts it to the field type.Unblocks the control-plane Docker build on every open PR.