Repository navigation
feat(control-plane): identify dataplane requests with its own User-Agent - #5536
Merged
Merged
Conversation
…trol-plane User-Agent
This was referenced Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control plane's server calls the dataplane API three ways, and none of them set a User-Agent, so its traffic showed up as the client default (or as Node's
node). It now sendshindsight-control-plane/<version>on all three:HindsightClientinstance (userAgent:). With the client change from feat(integrations): every integration identifies itself with its own User-Agent #5466 this goes out ashindsight-control-plane/<v> hindsight-client-typescript/<v>createClientinstancefetchcalls, throughgetDataplaneHeaders(), which every API route already usesThe version comes from the control plane's own
package.json. Browser-side calls only go to the control plane's own/api/*routes, and browsers don't allow setting this header anyway, so nothing changes there.Test:
tests/lib/hindsight-client.test.tschecks the value and that both the direct-fetch headers and the low-level client carry it. The full control-plane suite passes (294).