Repository navigation
fix(hermes): skip cron runs, honour HINDSIGHT_BANK_ID, add reflect_tags, re-probe an unreachable server - #5538
Merged
Conversation
…gs, re-probe an unreachable server - #4945: cron runs (agent_context="cron") are no longer auto-retained, per Hermes' provider contract. New retain_cron (default false) opts back in; the hindsight_retain tool still works in cron runs. - #5171: a non-empty HINDSIGHT_BANK_ID wins over bank_id in config.json, as documented. A bank_id_template still takes precedence. - #5170: new reflect_tags / reflect_tags_match scope reflect (tool and reflect prefetch). Opt-in; recall_tags still never apply to reflect. - #5221: only the server's own answer to the version probe is cached. An unreachable server (connection error, timeout, 5xx) is asked again after 60s instead of disabling append for the whole process. The probe tries /v1/version before /version, like the coding-agents client (#5286).
- A 404 on /v1/version plus a timeout or 5xx on /version used to cache 'old server' forever, the #5221 bug in a narrower case. Any unanswered path now keeps the result unknown and retries after the window; a non-JSON body still counts as an answer. - Drop a no-op line from the test's fake version server.
This was referenced Oct 14, 2026
Merged
1 task
This was referenced Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4945, closes #5171, closes #5170, closes #5221.
agent_context="cron") are no longer auto-retained, per Hermes' provider contract. Newretain_cron(defaultfalse) opts back in. Thehindsight_retaintool still works in cron runs.HINDSIGHT_BANK_IDwins overbank_idinconfig.json, as the README promised. Abank_id_templatestill takes precedence.reflect_tags/reflect_tags_matchscope reflect (the tool andrecall_prefetch_method: reflect). Opt-in;recall_tagsstill never apply to reflect, so existing installs are unchanged./v1/versionbefore/version(#5286). The 60s window keeps a hung server from stalling every turn on the probe timeout.README documents the three new settings and the env-var precedence; the docs page and docs skill are regenerated from it.
Tests: 11 new in
tests/test_provider.py; the 7 that cover the bugs fail on main, the other 4 guard unchanged behaviour.uv run pytest tests→ 138 passed.Manual test (real Hermes + real server)
Driven through Hermes' own
load_memory_provider+MemoryManager(hermes-agent checkout) against a localhindsight-api, once withorigin/main's plugin and once with this branch.retain_cron: truesaves it; primary runs still saved)HINDSIGHT_BANK_ID=env-bank,config.jsonbank_id: config-bankreflect_tags: team-a(andrecall_tags: team-b), bank has a team-a and a team-b factClosed #5424 as not planned separately.