Repository navigation
fix(consolidation): keep an UPDATE when the same response deletes that observation (#2550) - #5577
Merged
Merged
Conversation
1 task
nicoloboschi
changed the title
When one LLM response both updated and deleted an observation, the delete ran first and the update found no row, so the new state was lost while its source facts were stamped consolidated. Drop the delete in that case. Also read the #2550 test's results through list_memory_units instead of SQL.
nicoloboschi
force-pushed
the
test/consolidation-message-order-2550
branch
from
October 15, 2026 14:36
e5de73e to
2b736da
Compare
This was referenced Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things, both found while reproducing #2550.
1. Regression test for #2550 (real LLM + judge,
hs_llm_core). Session 1 opens on 07-01, session 2 says "React is my favorite" on 07-05, then session 1 is re-retained (samedocument_id) with a 07-10 message "svelte is my favorite". Consolidation must end on Svelte, both when the update keeps the session-startevent_dateand when it carries the last message's time.Passes 5/5 on gemini-3.1-flash-lite (the Core LLM job's model) and gemini-2.5-flash. gemini-2.5-flash-lite fails most runs: it creates "favorite is React" and "favorite is Svelte" as two separate observations instead of resolving the clash.
2. Fix: an UPDATE wins over a DELETE of the same observation. A response can rewrite an observation to its new state and also delete it. Deletes ran first, so the update found no row and was skipped while its source facts were stamped consolidated — the new knowledge was lost. Now the delete is dropped (with a warning). Covered by
test_consolidation_update_delete_same_observation.py, which fails without the fix.