Repository navigation
feat/recall prefer observations default - #5617
Merged
Merged
Conversation
Add recall_prefer_observations (env HINDSIGHT_API_RECALL_PREFER_OBSERVATIONS, default false), resolved env -> tenant -> bank. REST RecallRequest and the MCP recall tool now take prefer_observations: bool | None; None uses the resolved default, an explicit value still wins. Internal engine callers stay False. Control plane: tri-state setting in the bank config Recall section (inherit shows the resolved server value), and a Prefer observations switch in the recall playground that starts at the bank's resolved value.
- test: sort imports (ruff I001) - cli: --prefer-observations takes an optional bool so 'false' can override a bank default - ts client: doc says omitted uses bank recall_prefer_observations - test: MCP recall passes prefer_observations=None when omitted, explicit False through - docs: recall.mdx wording no longer contradicts the bank default - ui: dedicated recallServerDefaultState key; Recall section description covers dedup - ui: playground sends the shown value explicitly when the bank config failed to load
…swallow the query
… client test expects None default - python/ts update_bank_config wrappers take recall_prefer_observations (check-client-coverage) - python client test: omitted prefer_observations is None (bank default), not False
This was referenced Oct 16, 2026
1 task done
This was referenced Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5131
recall_prefer_observations(HINDSIGHT_API_RECALL_PREFER_OBSERVATIONS, defaultfalse— no behaviour change).prefer_observationsand MCPrecallparam are nowbool | None; omitted → bank-resolved default; explicit value wins. Engine internals (consolidation etc.) still default toFalse.--prefer-observationssends nothing when the flag is absent; Python client default is nowNone.test_27_observations_in_recall.py.Skipped the optional
accept_withrecall-options extension hook — the config default covers the MCP case.