Repository navigation
fix(api): re-check mental-model edits under the row lock so the vector matches the stored text - #5619
Merged
Merged
Conversation
…r matches the stored text A document edit embedded from a pre-image read off the lock; a concurrent edit could move the half the caller did not send, and the write then stored a vector for text the model no longer holds (#5297). The edit now takes the row lock, re-embeds only if that half moved, and takes the history snapshot from the locked row. Re-lands the #5513 part reverted in 65ef1bd. Fixes #5297
This was referenced Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5297. Re-lands the mental-model part of #5513 (reverted in 65ef1bd for unrelated reasons).
update_mental_modelembeds name + content from a read taken before the row lock. If a concurrent edit changes the half the caller didn't send, the write stored a vector for the old text.FOR UPDATErow lock trigger patches already use.Regression test
test_concurrent_edit_does_not_persist_a_stale_embeddingpauses a rename mid-embedding, commits a content edit, and checks the final vector matches a clean sequential edit. Fails on main, passes here.