Repository navigation
fix(tags): reject an unknown tags_match instead of widening it to "any" (#5371) - #5653
Merged
Merged
Conversation
…y" (#5371) MCP recall/reflect and GET /documents, /graph took tags_match as a plain string, and the shared parser fell back to "any" (which admits untagged rows) for anything it didn't recognise. Type all four MCP signatures and both routes as TagsMatch, list the five modes in the tool docstrings, and make the parser raise instead of falling back.
This was referenced Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5371.
A mistyped
tags_match(e.g.any-strict) on MCPrecall/reflectorGET /documents/GET /graphsilently ran asany, so untagged memories leaked into a recall meant to stay inside one tag.recall/reflect(both bank-id and session-bank copies) takeTagsMatch, so FastMCP rejects unknown modes and the tool schema lists all five. Docstrings name all five.GET /documentsandGET /graphtakeTagsMatch→ 422 on unknown modes, same as recall. OpenAPI + clients regenerated; control-plane documents proxy narrows to the new type._parse_tags_matchraises instead of falling back toany, so no future plain-string path can widen silently.Thanks @JayOfTheKeyboard and @koriyoshi2041 for the report and analysis.
Tests:
test_mcp_tools.py::TestRecallReflectTagsMatch,test_graph_filtering.py::test_unknown_tags_match_is_rejected,test_tags_visibility.py::test_parse_tags_match_rejects_unknown_mode.